Skip to content

Commit e5c2586

Browse files
committed
Update comments
1 parent 1948933 commit e5c2586

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/matrix.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,17 +205,17 @@ impl<A: MFloat> Matrix for RcArray<A, Ix2> {
205205
self.to_owned().norm_f()
206206
}
207207
fn svd(self) -> Result<(Self, Self::Vector, Self), LinalgError> {
208-
// XXX unnecessary clone
208+
// XXX unnecessary clone (should use into_owned())
209209
let (u, s, v) = self.to_owned().svd()?;
210210
Ok((u.into_shared(), s.into_shared(), v.into_shared()))
211211
}
212212
fn qr(self) -> Result<(Self, Self), LinalgError> {
213-
// XXX unnecessary clone
213+
// XXX unnecessary clone (should use into_owned())
214214
let (q, r) = self.to_owned().qr()?;
215215
Ok((q.into_shared(), r.into_shared()))
216216
}
217217
fn lu(self) -> Result<(Self::Permutator, Self, Self), LinalgError> {
218-
// XXX unnecessary clone
218+
// XXX unnecessary clone (should use into_owned())
219219
let (p, l, u) = self.to_owned().lu()?;
220220
Ok((p, l.into_shared(), u.into_shared()))
221221
}

src/square.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ impl<A: MFloat> SquareMatrix for Array<A, Ix2> {
6060

6161
impl<A: MFloat> SquareMatrix for RcArray<A, Ix2> {
6262
fn inv(self) -> Result<Self, LinalgError> {
63-
// XXX unnecessary clone
63+
// XXX unnecessary clone (should use into_owned())
6464
let i = self.to_owned().inv()?;
6565
Ok(i.into_shared())
6666
}

0 commit comments

Comments
 (0)