Merge branch 'master' into lapack

Author: termoshtt

.github/workflows/ndarray-linalg.yml

@@ -28,7 +28,7 @@ jobs:
     - uses: actions-rs/cargo@v1
       with:
         command: test
-        args: --manifest-path=ndarray-linalg/Cargo.toml --features=${{ matrix.feature }} --no-default-features
+        args: --manifest-path=ndarray-linalg/Cargo.toml --features=${{ matrix.feature }} --no-default-features --all-targets
 
   linux:
     runs-on: ubuntu-18.04
@@ -49,4 +49,4 @@ jobs:
     - uses: actions-rs/cargo@v1
       with:
         command: test
-        args: --manifest-path=ndarray-linalg/Cargo.toml --features=${{ matrix.feature }} --no-default-features
+        args: --manifest-path=ndarray-linalg/Cargo.toml --features=${{ matrix.feature }} --no-default-features --all-targets

lax/src/least_squares.rs

@@ -42,6 +42,10 @@ macro_rules! impl_least_squares {
                 }
                 let k = ::std::cmp::min(m, n);
                 let nrhs = 1;
+                let ldb = match a_layout {
+                    MatrixLayout::F { .. } => m.max(n),
+                    MatrixLayout::C { .. } => 1,
+                };
                 let rcond: Self::Real = -1.;
                 let mut singular_values: Vec<Self::Real> = vec![Self::Real::zero(); k as usize];
                 let mut rank: i32 = 0;
@@ -54,9 +58,7 @@ macro_rules! impl_least_squares {
                     a,
                     a_layout.lda(),
                     b,
-                    // this is the 'leading dimension of b', in the case where
-                    // b is a single vector, this is 1
-                    nrhs,
+                    ldb,
                     &mut singular_values,
                     rcond,
                     &mut rank,

lax/src/lib.rs

@@ -110,6 +110,7 @@ pub trait Lapack:
     + Triangular_
     + Tridiagonal_
     + Rcond_
+    + LeastSquaresSvdDivideConquer_
 {
 }