Merge pull request #958 from rust-ndarray/partial-eq-with-reference

Implement PartialEq for array == &array and &array == array

Author: bluss

RELEASES.md

@@ -1,3 +1,13 @@
+Version 0.15.1 (not released yet)
+===========================
+
+Enhancements
+------------
+
+- Arrays and views now implement PartialEq so that it's possible to compare
+  arrays with references to arrays and vice versa by [@bluss]
+
+
 Version 0.15.0 (2021-03-25)
 ===========================
 

src/arraytraits.rs

@@ -112,6 +112,34 @@ where
     }
 }
 
+/// Return `true` if the array shapes and all elements of `self` and
+/// `rhs` are equal. Return `false` otherwise.
+impl<'a, A, B, S, S2, D> PartialEq<&'a ArrayBase<S2, D>> for ArrayBase<S, D>
+where
+    A: PartialEq<B>,
+    S: Data<Elem = A>,
+    S2: Data<Elem = B>,
+    D: Dimension,
+{
+    fn eq(&self, rhs: &&ArrayBase<S2, D>) -> bool {
+        *self == **rhs
+    }
+}
+
+/// Return `true` if the array shapes and all elements of `self` and
+/// `rhs` are equal. Return `false` otherwise.
+impl<'a, A, B, S, S2, D> PartialEq<ArrayBase<S2, D>> for &'a ArrayBase<S, D>
+where
+    A: PartialEq<B>,
+    S: Data<Elem = A>,
+    S2: Data<Elem = B>,
+    D: Dimension,
+{
+    fn eq(&self, rhs: &ArrayBase<S2, D>) -> bool {
+        **self == *rhs
+    }
+}
+
 impl<S, D> Eq for ArrayBase<S, D>
 where
     D: Dimension,

tests/windows.rs

@@ -133,22 +133,22 @@ fn test_window_neg_stride() {
 
     itertools::assert_equal(
         array.slice(s![.., ..;-1]).windows((2, 2)),
-        answer.iter().map(|a| a.view())
+        answer.iter()
     );
 
     answer.invert_axis(Axis(0));
     answer.map_inplace(|a| a.invert_axis(Axis(0)));
 
     itertools::assert_equal(
         array.slice(s![..;-1, ..;-1]).windows((2, 2)),
-        answer.iter().map(|a| a.view())
+        answer.iter()
     );
 
     answer.invert_axis(Axis(1));
     answer.map_inplace(|a| a.invert_axis(Axis(1)));
 
     itertools::assert_equal(
         array.slice(s![..;-1, ..]).windows((2, 2)),
-        answer.iter().map(|a| a.view())
+        answer.iter()
     );
 }