Fix cargo clippy

Signed-off-by: Gris Ge <[email protected]>

Author: cathay4t

src/address/attribute.rs

@@ -60,7 +60,7 @@ impl Nla for AddressAttribute {
                     IPV4_ADDR_LEN
                 }
             }
-            Self::Label(ref string) => string.as_bytes().len() + 1,
+            Self::Label(ref string) => string.len() + 1,
 
             Self::Flags(_) => size_of::<u32>(),
 

src/lib.rs

@@ -1,5 +1,27 @@
 // SPDX-License-Identifier: MIT
 
+//! The `netlink-packet-route` crate is designed to abstract Netlink route
+//! protocol(`rtnetlink`) packet into Rust data types. The goal of this crate is
+//! saving netlink user from reading Kernel Netlink codes.
+//!
+//! This crate grouped Netlink route protocol into these modules:
+//!  * `link`: NIC interface, similar to to `ip link` command.
+//!  * `address`: IP address, similar to `ip address` command.
+//!  * `route`: Route, similar to `ip route` command.
+//!  * `rule`: Route rule, similar to `ip rule` command.
+//!  * `tc`: Traffic control, similar to `tc` command.
+//!  * `neighbour`: Neighbour, similar to `ip neighbour` command.
+//!  * `neighbour_table`: Neighbour table, similar to `ip ntable` command.
+//!  * `nsid`: Namespace, similar to `ip netns` command.
+//!
+//! At the top level of this crate, we also provide:
+//!  * [AddressFamily]
+//!
+//! Normally, you should use [`rtnetlink`][rtnetlink_url] instead of using this
+//! crate directly.
+//!
+//! [rtnetlink_url]: https://docs.rs/rtnetlink
+
 pub mod address;
 pub mod link;
 pub mod neighbour;
@@ -42,28 +64,6 @@ pub use self::address_family_fallback::AddressFamily;
 pub use self::ip::IpProtocol;
 pub use self::message::{RouteNetlinkMessage, RouteNetlinkMessageBuffer};
 
-/// The `netlink-packet-route` crate is designed to abstract Netlink route
-/// protocol(`rtnetlink`) packet into Rust data types. The goal of this crate is
-/// saving netlink user from reading Kernel Netlink codes.
-///
-/// This crate grouped Netlink route protocol into these modules:
-///  * `link`: NIC interface, similar to to `ip link` command.
-///  * `address`: IP address, similar to `ip address` command.
-///  * `route`: Route, similar to `ip route` command.
-///  * `rule`: Route rule, similar to `ip rule` command.
-///  * `tc`: Traffic control, similar to `tc` command.
-///  * `neighbour`: Neighbour, similar to `ip neighbour` command.
-///  * `neighbour_table`: Neighbour table, similar to `ip ntable` command.
-///  * `nsid`: Namespace, similar to `ip netns` command.
-///
-/// At the top level of this crate, we also provide:
-///  * [AddressFamily]
-///
-/// Normally, you should use [`rtnetlink`][rtnetlink_url] instead of using this
-/// crate directly.
-///
-/// [rtnetlink_url]: https://docs.rs/rtnetlink
-
 #[macro_use]
 extern crate netlink_packet_utils;
 

src/link/attribute.rs

@@ -188,7 +188,7 @@ impl Nla for LinkAttribute {
             Self::IfName(string)
             | Self::Qdisc(string)
             | Self::IfAlias(string)
-            | Self::PhysPortName(string) => string.as_bytes().len() + 1,
+            | Self::PhysPortName(string) => string.len() + 1,
 
             Self::Mode(_) | Self::Carrier(_) | Self::ProtoDown(_) => 1,
 

src/link/prop_list.rs

@@ -22,7 +22,7 @@ impl Nla for Prop {
     fn value_len(&self) -> usize {
         use self::Prop::*;
         match self {
-            AltIfName(ref string) => string.as_bytes().len() + 1,
+            AltIfName(ref string) => string.len() + 1,
             Other(nla) => nla.value_len()
         }
     }

src/link/sriov/broadcast.rs

@@ -26,7 +26,7 @@ buffer!(VfInfoBroadcastBuffer(VF_INFO_BROADCAST_LEN) {
     addr: (slice, 0..VF_INFO_BROADCAST_LEN),
 });
 
-impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<VfInfoBroadcastBuffer<&'a T>>
+impl<T: AsRef<[u8]> + ?Sized> Parseable<VfInfoBroadcastBuffer<&T>>
     for VfInfoBroadcast
 {
     fn parse(buf: &VfInfoBroadcastBuffer<&T>) -> Result<Self, DecodeError> {

src/link/sriov/guid.rs

@@ -22,9 +22,7 @@ buffer!(VfInfoGuidBuffer(VF_INFO_GUID_LEN) {
     guid: (u64, 4..12),
 });
 
-impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<VfInfoGuidBuffer<&'a T>>
-    for VfInfoGuid
-{
+impl<T: AsRef<[u8]> + ?Sized> Parseable<VfInfoGuidBuffer<&T>> for VfInfoGuid {
     fn parse(buf: &VfInfoGuidBuffer<&T>) -> Result<Self, DecodeError> {
         Ok(Self::new(buf.vf_id(), buf.guid()))
     }

src/link/sriov/link_state.rs

@@ -22,7 +22,7 @@ buffer!(VfInfoLinkStateBuffer(VF_INFO_LINK_STATE_LEN) {
     state: (u32, 4..8),
 });
 
-impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<VfInfoLinkStateBuffer<&'a T>>
+impl<T: AsRef<[u8]> + ?Sized> Parseable<VfInfoLinkStateBuffer<&T>>
     for VfInfoLinkState
 {
     fn parse(buf: &VfInfoLinkStateBuffer<&T>) -> Result<Self, DecodeError> {

src/link/sriov/mac.rs

@@ -33,9 +33,7 @@ buffer!(VfInfoMacBuffer(VF_INFO_MAC_LEN) {
     mac: (slice, 4..VF_INFO_MAC_LEN),
 });
 
-impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<VfInfoMacBuffer<&'a T>>
-    for VfInfoMac
-{
+impl<T: AsRef<[u8]> + ?Sized> Parseable<VfInfoMacBuffer<&T>> for VfInfoMac {
     fn parse(buf: &VfInfoMacBuffer<&T>) -> Result<Self, DecodeError> {
         Ok(Self::new(buf.vf_id(), buf.mac()))
     }

src/link/sriov/rate.rs

@@ -28,9 +28,7 @@ buffer!(VfInfoRateBuffer(VF_INFO_RATE_LEN) {
     max_tx_rate: (u32, 8..12)
 });
 
-impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<VfInfoRateBuffer<&'a T>>
-    for VfInfoRate
-{
+impl<T: AsRef<[u8]> + ?Sized> Parseable<VfInfoRateBuffer<&T>> for VfInfoRate {
     fn parse(buf: &VfInfoRateBuffer<&T>) -> Result<Self, DecodeError> {
         Ok(Self {
             vf_id: buf.vf_id(),

src/link/sriov/rss_query.rs

@@ -22,7 +22,7 @@ buffer!(VfInfoRssQueryEnBuffer(VF_INFO_RSS_QUERY_EN_LEN) {
     setting: (u32, 4..8),
 });
 
-impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<VfInfoRssQueryEnBuffer<&'a T>>
+impl<T: AsRef<[u8]> + ?Sized> Parseable<VfInfoRssQueryEnBuffer<&T>>
     for VfInfoRssQueryEn
 {
     fn parse(buf: &VfInfoRssQueryEnBuffer<&T>) -> Result<Self, DecodeError> {