mls: use references in args where possible

Signed-off-by: Yuki Kishimoto <[email protected]>

Author: yukibtc

crates/nostr-mls/examples/mls_memory.rs

@@ -50,8 +50,8 @@ async fn main() -> Result<()> {
         "Bob & Alice",
         "A secret chat between Bob and Alice",
         &alice_keys.public_key,
-        vec![bob_keys.public_key()],
-        vec![bob_key_package],
+        &[bob_keys.public_key()],
+        &[bob_key_package],
         vec![alice_keys.public_key()],
         vec![RelayUrl::parse("ws://localhost:8080").unwrap()],
     )?;

crates/nostr-mls/examples/mls_sqlite.rs

@@ -57,8 +57,8 @@ async fn main() -> Result<()> {
         "Bob & Alice",
         "A secret chat between Bob and Alice",
         &alice_keys.public_key,
-        vec![bob_keys.public_key()],
-        vec![bob_key_package],
+        &[bob_keys.public_key()],
+        &[bob_key_package],
         vec![alice_keys.public_key()],
         vec![RelayUrl::parse("ws://localhost:8080").unwrap()],
     )?;

crates/nostr-mls/src/groups.rs

@@ -258,8 +258,8 @@ where
         name: S1,
         description: S2,
         creator_public_key: &PublicKey,
-        member_pubkeys: Vec<PublicKey>,
-        member_key_packages: Vec<KeyPackage>,
+        member_pubkeys: &[PublicKey],
+        member_key_packages: &[KeyPackage],
         admins: Vec<PublicKey>,
         group_relays: Vec<RelayUrl>,
     ) -> Result<CreateGroupResult, Error>
@@ -268,7 +268,7 @@ where
         S2: Into<String>,
     {
         // Validate group members
-        self.validate_group_members(creator_public_key, &member_pubkeys, &admins)?;
+        self.validate_group_members(creator_public_key, member_pubkeys, &admins)?;
 
         let (credential, signer) = self.generate_credential_with_key(creator_public_key)?;
 
@@ -325,7 +325,7 @@ where
 
         // Add members to the group
         let (_, welcome_out, _group_info) =
-            mls_group.add_members(&self.provider, &signer, member_key_packages.as_slice())?;
+            mls_group.add_members(&self.provider, &signer, member_key_packages)?;
 
         // Merge the pending commit adding the memebers
         mls_group.merge_pending_commit(&self.provider)?;

crates/nostr-mls/src/key_packages.rs

@@ -120,7 +120,7 @@ where
     /// # Arguments
     ///
     /// * `key_package` - The key package to delete
-    pub fn delete_key_package_from_storage(&self, key_package: KeyPackage) -> Result<(), Error> {
+    pub fn delete_key_package_from_storage(&self, key_package: &KeyPackage) -> Result<(), Error> {
         let hash_ref = key_package.hash_ref(self.provider.crypto())?;
 
         self.provider
@@ -245,7 +245,7 @@ mod tests {
 
         // Delete the key package
         deletion_mls
-            .delete_key_package_from_storage(key_package)
+            .delete_key_package_from_storage(&key_package)
             .expect("Failed to delete key package");
     }
 

crates/nostr-mls/src/welcomes.rs

@@ -253,10 +253,10 @@ where
     /// - The group data extension cannot be extracted
     fn parse_serialized_welcome(
         &self,
-        welcome_message: Vec<u8>,
+        mut welcome_message: &[u8],
     ) -> Result<(StagedWelcome, NostrGroupDataExtension), Error> {
         // Parse welcome message
-        let welcome_message_in = MlsMessageIn::tls_deserialize(&mut welcome_message.as_slice())?;
+        let welcome_message_in = MlsMessageIn::tls_deserialize(&mut welcome_message)?;
 
         let welcome: Welcome = match welcome_message_in.extract() {
             MlsMessageBodyIn::Welcome(welcome) => welcome,
@@ -324,7 +324,7 @@ where
             }
         };
 
-        let welcome_preview = match self.parse_serialized_welcome(hex_content) {
+        let welcome_preview = match self.parse_serialized_welcome(&hex_content) {
             Ok((staged_welcome, nostr_group_data)) => WelcomePreview {
                 staged_welcome,
                 nostr_group_data,