mls-storage: make failure_reason optional

Updated `failure_reason` to be an `Option<String>` in structs, database schema, and related code.

Signed-off-by: Yuki Kishimoto <[email protected]>

Author: erskingardner

crates/nostr-mls-memory-storage/src/lib.rs

@@ -463,7 +463,7 @@ mod tests {
             welcome_event_id: Some(event_id),
             processed_at: Timestamp::now(),
             state: ProcessedWelcomeState::Processed,
-            failure_reason: "".to_string(),
+            failure_reason: None,
         };
 
         // Save the processed welcome
@@ -571,7 +571,7 @@ mod tests {
             message_event_id: Some(event_id),
             processed_at: Timestamp::now(),
             state: ProcessedMessageState::Processed,
-            failure_reason: "".to_string(),
+            failure_reason: None,
         };
 
         // Save the processed message

crates/nostr-mls-sqlite-storage/migrations/V100__initial.sql

@@ -67,7 +67,7 @@ CREATE TABLE IF NOT EXISTS processed_messages (
     message_event_id BLOB, -- Message event ID as byte array
     processed_at INTEGER NOT NULL,
     state TEXT NOT NULL,
-    failure_reason TEXT NOT NULL
+    failure_reason TEXT
 );
 
 -- Create index on message_event_id for faster lookups
@@ -105,7 +105,7 @@ CREATE TABLE IF NOT EXISTS processed_welcomes (
     welcome_event_id BLOB, -- Welcome event ID as byte array
     processed_at INTEGER NOT NULL,
     state TEXT NOT NULL,
-    failure_reason TEXT NOT NULL
+    failure_reason TEXT
 );
 
 -- Create index on welcome_event_id for faster lookups

crates/nostr-mls-sqlite-storage/src/db.rs

@@ -162,7 +162,7 @@ pub fn row_to_processed_message(row: &Row) -> SqliteResult<ProcessedMessage> {
         row.get_ref("message_event_id")?.as_blob_or_null()?;
     let processed_at_value: u64 = row.get("processed_at")?;
     let state_str: &str = row.get_ref("state")?.as_str()?;
-    let failure_reason: String = row.get("failure_reason")?;
+    let failure_reason: Option<String> = row.get("failure_reason")?;
 
     // Parse values
     let wrapper_event_id: EventId = EventId::from_slice(wrapper_event_id_blob)
@@ -249,7 +249,7 @@ pub fn row_to_processed_welcome(row: &Row) -> SqliteResult<ProcessedWelcome> {
         row.get_ref("welcome_event_id")?.as_blob_or_null()?;
     let processed_at_value: u64 = row.get("processed_at")?;
     let state_str: &str = row.get_ref("state")?.as_str()?;
-    let failure_reason: String = row.get("failure_reason")?;
+    let failure_reason: Option<String> = row.get("failure_reason")?;
 
     // Parse values
     let wrapper_event_id: EventId = EventId::from_slice(wrapper_event_id_blob)

crates/nostr-mls-sqlite-storage/src/messages.rs

@@ -201,7 +201,7 @@ mod tests {
             message_event_id: Some(message_event_id),
             processed_at: Timestamp::from(1_000_000_000u64),
             state: ProcessedMessageState::Processed,
-            failure_reason: "".to_string(),
+            failure_reason: None,
         };
 
         // Save the processed message

crates/nostr-mls-sqlite-storage/src/welcomes.rs

@@ -241,7 +241,7 @@ mod tests {
             welcome_event_id: Some(welcome_event_id),
             processed_at: Timestamp::from(1_000_000_000u64),
             state: ProcessedWelcomeState::Processed,
-            failure_reason: "".to_string(),
+            failure_reason: None,
         };
 
         // Save the processed welcome

crates/nostr-mls-storage/src/messages/types.rs

@@ -21,7 +21,7 @@ pub struct ProcessedMessage {
     /// The state of the message
     pub state: ProcessedMessageState,
     /// The reason the message failed to be processed
-    pub failure_reason: String,
+    pub failure_reason: Option<String>,
 }
 
 /// This is the processed rumor message that represents a message in a group
@@ -163,11 +163,11 @@ mod tests {
     fn test_processed_message_serialization() {
         // Create a processed message to test serialization
         let processed_message = ProcessedMessage {
-            wrapper_event_id: EventId::all_zeros(), // Using all_zeros for testing
+            wrapper_event_id: EventId::all_zeros(),
             message_event_id: None,
             processed_at: Timestamp::now(),
             state: ProcessedMessageState::Processed,
-            failure_reason: String::new(),
+            failure_reason: None,
         };
 
         let serialized = serde_json::to_value(&processed_message).unwrap();

crates/nostr-mls-storage/src/welcomes/types.rs

@@ -21,7 +21,7 @@ pub struct ProcessedWelcome {
     /// The state of the welcome
     pub state: ProcessedWelcomeState,
     /// The reason the welcome failed to be processed
-    pub failure_reason: String,
+    pub failure_reason: Option<String>,
 }
 
 /// A welcome message
@@ -309,11 +309,11 @@ mod tests {
             welcome_event_id: None,
             processed_at: Timestamp::now(),
             state: ProcessedWelcomeState::Processed,
-            failure_reason: String::new(),
+            failure_reason: None,
         };
 
         let serialized = serde_json::to_value(&processed_welcome).unwrap();
         assert_eq!(serialized["state"], json!("processed"));
-        assert_eq!(serialized["failure_reason"], json!(""));
+        assert_eq!(serialized["failure_reason"], json!(null));
     }
 }