aml: tests: fix all clippy warnings

Author: 00xc

aml/src/name_object.rs

@@ -252,7 +252,7 @@ mod tests {
         let mut context = crate::test_utils::make_test_context();
 
         check_ok!(
-            name_seg().parse(&[b'A', b'F', b'3', b'Z'], &mut context),
+            name_seg().parse(b"AF3Z", &mut context),
             NameSeg([b'A', b'F', b'3', b'Z']),
             &[]
         );
@@ -292,12 +292,12 @@ mod tests {
         let mut context = crate::test_utils::make_test_context();
 
         check_ok!(
-            name_string().parse(&[b'^', b'A', b'B', b'C', b'D'], &mut context),
+            name_string().parse(b"^ABCD", &mut context),
             AmlName::from_str("^ABCD").unwrap(),
             &[]
         );
         check_ok!(
-            name_string().parse(&[b'^', b'^', b'^', b'A', b'B', b'C', b'D'], &mut context),
+            name_string().parse(b"^^^ABCD", &mut context),
             AmlName::from_str("^^^ABCD").unwrap(),
             &[]
         );

aml/src/namespace.rs

@@ -600,12 +600,12 @@ mod tests {
 
     #[test]
     fn test_is_normal() {
-        assert_eq!(AmlName::root().is_normal(), true);
-        assert_eq!(AmlName::from_str("\\_SB.PCI0.VGA").unwrap().is_normal(), true);
-        assert_eq!(AmlName::from_str("\\_SB.^PCI0.VGA").unwrap().is_normal(), false);
-        assert_eq!(AmlName::from_str("\\^_SB.^^PCI0.VGA").unwrap().is_normal(), false);
-        assert_eq!(AmlName::from_str("_SB.^^PCI0.VGA").unwrap().is_normal(), false);
-        assert_eq!(AmlName::from_str("_SB.PCI0.VGA").unwrap().is_normal(), true);
+        assert!(AmlName::root().is_normal());
+        assert!(AmlName::from_str("\\_SB.PCI0.VGA").unwrap().is_normal());
+        assert!(!AmlName::from_str("\\_SB.^PCI0.VGA").unwrap().is_normal());
+        assert!(!AmlName::from_str("\\^_SB.^^PCI0.VGA").unwrap().is_normal());
+        assert!(!AmlName::from_str("_SB.^^PCI0.VGA").unwrap().is_normal());
+        assert!(AmlName::from_str("_SB.PCI0.VGA").unwrap().is_normal());
     }
 
     #[test]
@@ -638,22 +638,22 @@ mod tests {
 
     #[test]
     fn test_is_absolute() {
-        assert_eq!(AmlName::root().is_absolute(), true);
-        assert_eq!(AmlName::from_str("\\_SB.PCI0.VGA").unwrap().is_absolute(), true);
-        assert_eq!(AmlName::from_str("\\_SB.^PCI0.VGA").unwrap().is_absolute(), true);
-        assert_eq!(AmlName::from_str("\\^_SB.^^PCI0.VGA").unwrap().is_absolute(), true);
-        assert_eq!(AmlName::from_str("_SB.^^PCI0.VGA").unwrap().is_absolute(), false);
-        assert_eq!(AmlName::from_str("_SB.PCI0.VGA").unwrap().is_absolute(), false);
+        assert!(AmlName::root().is_absolute());
+        assert!(AmlName::from_str("\\_SB.PCI0.VGA").unwrap().is_absolute());
+        assert!(AmlName::from_str("\\_SB.^PCI0.VGA").unwrap().is_absolute());
+        assert!(AmlName::from_str("\\^_SB.^^PCI0.VGA").unwrap().is_absolute());
+        assert!(!AmlName::from_str("_SB.^^PCI0.VGA").unwrap().is_absolute());
+        assert!(!AmlName::from_str("_SB.PCI0.VGA").unwrap().is_absolute());
     }
 
     #[test]
     fn test_search_rules_apply() {
-        assert_eq!(AmlName::root().search_rules_apply(), false);
-        assert_eq!(AmlName::from_str("\\_SB").unwrap().search_rules_apply(), false);
-        assert_eq!(AmlName::from_str("^VGA").unwrap().search_rules_apply(), false);
-        assert_eq!(AmlName::from_str("_SB.PCI0.VGA").unwrap().search_rules_apply(), false);
-        assert_eq!(AmlName::from_str("VGA").unwrap().search_rules_apply(), true);
-        assert_eq!(AmlName::from_str("_SB").unwrap().search_rules_apply(), true);
+        assert!(!AmlName::root().search_rules_apply());
+        assert!(!AmlName::from_str("\\_SB").unwrap().search_rules_apply());
+        assert!(!AmlName::from_str("^VGA").unwrap().search_rules_apply());
+        assert!(!AmlName::from_str("_SB.PCI0.VGA").unwrap().search_rules_apply());
+        assert!(AmlName::from_str("VGA").unwrap().search_rules_apply());
+        assert!(AmlName::from_str("_SB").unwrap().search_rules_apply());
     }
 
     #[test]

aml/src/pkg_length.rs

@@ -189,7 +189,7 @@ mod tests {
 
         check_ok!(
             pkg_length()
-                .feed(|length| crate::parser::take_to_end_of_pkglength(length))
+                .feed(crate::parser::take_to_end_of_pkglength)
                 .parse(&[0x05, 0x01, 0x02, 0x03, 0x04, 0xff, 0xff, 0xff], &mut context),
             &[0x01, 0x02, 0x03, 0x04],
             &[0xff, 0xff, 0xff]

aml/src/term_object.rs

@@ -1056,7 +1056,7 @@ mod test {
         );
         check_ok_value!(
             computational_data().parse(&[0xff, 0x98, 0xc3], &mut context),
-            AmlValue::Integer(u64::max_value()),
+            AmlValue::Integer(u64::MAX),
             &[0x98, 0xc3]
         );
         check_ok_value!(

aml/src/test_utils.rs

@@ -125,10 +125,7 @@ pub(crate) fn crudely_cmp_values(a: &AmlValue, b: &AmlValue) -> bool {
     use crate::value::MethodCode;
 
     match a {
-        AmlValue::Uninitialized => match b {
-            AmlValue::Uninitialized => true,
-            _ => false,
-        },
+        AmlValue::Uninitialized => matches!(b, AmlValue::Uninitialized),
         AmlValue::Boolean(a) => match b {
             AmlValue::Boolean(b) => a == b,
             _ => false,
@@ -151,10 +148,7 @@ pub(crate) fn crudely_cmp_values(a: &AmlValue, b: &AmlValue) -> bool {
             }
             _ => false,
         },
-        AmlValue::Device => match b {
-            AmlValue::Device => true,
-            _ => false,
-        },
+        AmlValue::Device => matches!(b, AmlValue::Device),
         AmlValue::Method { flags, code } => match b {
             AmlValue::Method { flags: b_flags, code: b_code } => {
                 if flags != b_flags {
@@ -195,7 +189,7 @@ pub(crate) fn crudely_cmp_values(a: &AmlValue, b: &AmlValue) -> bool {
         AmlValue::Package(a) => match b {
             AmlValue::Package(b) => {
                 for (a, b) in a.iter().zip(b) {
-                    if crudely_cmp_values(a, b) == false {
+                    if !crudely_cmp_values(a, b) {
                         return false;
                     }
                 }
@@ -210,9 +204,6 @@ pub(crate) fn crudely_cmp_values(a: &AmlValue, b: &AmlValue) -> bool {
             }
             _ => false,
         },
-        AmlValue::ThermalZone => match b {
-            AmlValue::ThermalZone => true,
-            _ => false,
-        },
+        AmlValue::ThermalZone => matches!(b, AmlValue::ThermalZone),
     }
 }