Skip to content

Conversation

pjhades
Copy link
Contributor

@pjhades pjhades commented Nov 18, 2024

The AML resource descriptor structs are useful in device initialization, however the fields of such structs, except IrqDescriptor, are private without any interface for accessing them. This commit makes those fields public.

Close #227

The AML resource descriptor structs are useful in device initialization,
however the fields of such structs, except `IrqDescriptor`, are private
without any interface for accessing them. This commit makes those fields
public.
Copy link
Member

@IsaacWoods IsaacWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@IsaacWoods IsaacWoods merged commit e46723a into rust-osdev:main Nov 20, 2024
4 checks passed
@pjhades pjhades deleted the make-resource-descriptor-fields-public branch November 20, 2024 14:06
IsaacWoods pushed a commit to IsaacWoods/acpi that referenced this pull request Jan 30, 2025
The AML resource descriptor structs are useful in device initialization,
however the fields of such structs, except `IrqDescriptor`, are private
without any interface for accessing them. This commit makes those fields
public.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visibility of aml::resource::IOPortDescriptor members
2 participants