Skip to content

[WIP] uefi: use core::net types in public API, remove net type duplicates, use uefi-raw's net types #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] uefi: use core::net types in public API, remove net type duplicates, use uefi-raw's net types #1645

wants to merge 1 commit into from
+100 −186

Conversation

phip1611
Copy link
Member

@phip1611 phip1611 commented Apr 21, 2025 •
edited
Loading

This PR started as a "big PR" to address the vision in #1575. In the meantime, multiple smaller PRs have been spitted out and merged before. This is the final PR to close the ticket.

TL;DR:

  • use core::net types in public API in uefi without exception
  • remove net type duplicates in uefi
  • use uefi-raw's net types

Closes #1575.

Steps to Undraft

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 marked this pull request as draft April 21, 2025 08:44
@phip1611 phip1611 changed the title XXX WIP Core net uefi-raw and uefi: use core::net types where possible, remove duplicated types Apr 21, 2025
@phip1611 phip1611 marked this pull request as ready for review April 21, 2025 09:13
@phip1611 phip1611 mentioned this pull request Apr 21, 2025
Open
@phip1611 phip1611 force-pushed the core-net branch 4 times, most recently from 728dc3b to 6291e95 Compare April 21, 2025 10:57
@phip1611
Copy link
Member Author

phip1611 commented Apr 21, 2025 •
edited
Loading

I personally see this as a major step forward. On the other hand, I'm biased 😁 I'm looking forward to the discussion and other's ideas!

@phip1611 phip1611 force-pushed the core-net branch 2 times, most recently from c39462e to 17109fc Compare April 21, 2025 12:13
@phip1611 phip1611 mentioned this pull request Apr 21, 2025
Closed
15 tasks
@phip1611 phip1611 force-pushed the core-net branch 2 times, most recently from f36c480 to 86aa5ce Compare April 21, 2025 17:45
@phip1611 phip1611 mentioned this pull request May 5, 2025
Open
13 tasks
nicholasbishop
nicholasbishop reviewed May 7, 2025
View reviewed changes
@phip1611 phip1611 marked this pull request as draft May 19, 2025 19:59
@phip1611 phip1611 self-assigned this May 19, 2025
@phip1611 phip1611 changed the title uefi-raw and uefi: use core::net types where possible, remove duplicated types [WIP] uefi-raw and uefi: use core::net types where possible, remove duplicated types May 19, 2025
@phip1611 phip1611 mentioned this pull request Jun 15, 2025
Closed
4 tasks
@phip1611 phip1611 force-pushed the core-net branch 2 times, most recently from 2b7510a to a836560 Compare September 16, 2025 06:45
@phip1611 phip1611 changed the title [WIP] uefi-raw and uefi: use core::net types where possible, remove duplicated types [WIP] uefi: use core::net types in public API, remove net type duplicates, use uefi-raw's net types Sep 16, 2025
@phip1611
uefi: remove duplicated types, use uefi-raw's IpAddress
e6db490 
This does not use core::net::IpAddr in all possible public interfaces.
Although there is opportunity for that, this commit only makes `uefi`
compatible with the new `uefi-raw` type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasbishop nicholasbishop nicholasbishop left review comments

Assignees

@phip1611 phip1611

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: use core::net IP address types in uefi's public API
2 participants
@phip1611 @nicholasbishop