Fix some warnings (#243)

Author: phil-opp

src/instructions/mod.rs

@@ -2,8 +2,6 @@
 
 //! Special x86_64 instructions.
 
-use crate::VirtAddr;
-
 pub mod interrupts;
 pub mod port;
 pub mod random;
@@ -58,12 +56,12 @@ pub fn bochs_breakpoint() {
 /// instructions to execute.
 #[cfg(feature = "inline_asm")]
 #[inline(always)]
-pub fn read_rip() -> VirtAddr {
+pub fn read_rip() -> crate::VirtAddr {
     let rip: u64;
     unsafe {
         asm!(
             "lea {}, [rip]", out(reg) rip, options(nostack, nomem)
         );
     }
-    VirtAddr::new(rip)
+    crate::VirtAddr::new(rip)
 }

src/structures/gdt.rs

@@ -1,10 +1,7 @@
 //! Types for the Global Descriptor Table and segment selectors.
 
+use crate::structures::tss::TaskStateSegment;
 use crate::PrivilegeLevel;
-use crate::{
-    structures::{tss::TaskStateSegment, DescriptorTablePointer},
-    VirtAddr,
-};
 use bit_field::BitField;
 use bitflags::bitflags;
 use core::fmt;
@@ -221,10 +218,10 @@ impl GlobalDescriptorTable {
     /// Creates the descriptor pointer for this table. This pointer can only be
     /// safely used if the table is never modified or destroyed while in use.
     #[cfg(feature = "instructions")]
-    fn pointer(&self) -> DescriptorTablePointer {
+    fn pointer(&self) -> super::DescriptorTablePointer {
         use core::mem::size_of;
-        DescriptorTablePointer {
-            base: VirtAddr::new(self.table.as_ptr() as u64),
+        super::DescriptorTablePointer {
+            base: crate::VirtAddr::new(self.table.as_ptr() as u64),
             limit: (self.next_free * size_of::<u64>() - 1) as u16,
         }
     }

src/structures/idt.rs

@@ -9,7 +9,7 @@
 
 //! Provides types for the Interrupt Descriptor Table and its entries.
 
-use crate::{structures::DescriptorTablePointer, PrivilegeLevel, VirtAddr};
+use crate::{PrivilegeLevel, VirtAddr};
 use bit_field::BitField;
 use bitflags::bitflags;
 use core::fmt;
@@ -438,9 +438,9 @@ impl InterruptDescriptorTable {
     /// Creates the descriptor pointer for this table. This pointer can only be
     /// safely used if the table is never modified or destroyed while in use.
     #[cfg(feature = "instructions")]
-    fn pointer(&self) -> DescriptorTablePointer {
+    fn pointer(&self) -> crate::structures::DescriptorTablePointer {
         use core::mem::size_of;
-        DescriptorTablePointer {
+        crate::structures::DescriptorTablePointer {
             base: VirtAddr::new(self as *const _ as u64),
             limit: (size_of::<Self>() - 1) as u16,
         }

src/structures/paging/page_table.rs

@@ -198,6 +198,7 @@ impl PageTable {
         }
     }
 
+    /// Creates an empty page table.
     #[cfg(not(feature = "const_fn"))]
     #[inline]
     pub fn new() -> Self {