Revert "argument passed by reference, more efficient if passed by value"

This reverts commit fd252c1.

Author: AntoineSebert

src/addr.rs

@@ -148,31 +148,31 @@ impl VirtAddr {
 
     /// Returns the 12-bit page offset of this virtual address.
     #[inline]
-    pub fn page_offset(self) -> PageOffset {
+    pub fn page_offset(&self) -> PageOffset {
         PageOffset::new_truncate(self.0 as u16)
     }
 
     /// Returns the 9-bit level 1 page table index.
     #[inline]
-    pub fn p1_index(self) -> PageTableIndex {
+    pub fn p1_index(&self) -> PageTableIndex {
         PageTableIndex::new_truncate((self.0 >> 12) as u16)
     }
 
     /// Returns the 9-bit level 2 page table index.
     #[inline]
-    pub fn p2_index(self) -> PageTableIndex {
+    pub fn p2_index(&self) -> PageTableIndex {
         PageTableIndex::new_truncate((self.0 >> 12 >> 9) as u16)
     }
 
     /// Returns the 9-bit level 3 page table index.
     #[inline]
-    pub fn p3_index(self) -> PageTableIndex {
+    pub fn p3_index(&self) -> PageTableIndex {
         PageTableIndex::new_truncate((self.0 >> 12 >> 9 >> 9) as u16)
     }
 
     /// Returns the 9-bit level 4 page table index.
     #[inline]
-    pub fn p4_index(self) -> PageTableIndex {
+    pub fn p4_index(&self) -> PageTableIndex {
         PageTableIndex::new_truncate((self.0 >> 12 >> 9 >> 9 >> 9) as u16)
     }
 }
@@ -289,7 +289,7 @@ impl PhysAddr {
 
     /// Convenience method for checking if a physical address is null.
     #[inline]
-    pub fn is_null(self) -> bool {
+    pub fn is_null(&self) -> bool {
         self.0 == 0
     }
 

src/instructions/random.rs

@@ -21,7 +21,7 @@ impl RdRand {
     /// Uniformly sampled u64.
     /// May fail in rare circumstances or heavy load.
     #[inline]
-    pub fn get_u64(self) -> Option<u64> {
+    pub fn get_u64(&self) -> Option<u64> {
         let mut res: u64 = 0;
         unsafe {
             match core::arch::x86_64::_rdrand64_step(&mut res) {
@@ -36,7 +36,7 @@ impl RdRand {
     /// Uniformly sampled u32.
     /// May fail in rare circumstances or heavy load.
     #[inline]
-    pub fn get_u32(self) -> Option<u32> {
+    pub fn get_u32(&self) -> Option<u32> {
         let mut res: u32 = 0;
         unsafe {
             match core::arch::x86_64::_rdrand32_step(&mut res) {
@@ -51,7 +51,7 @@ impl RdRand {
     /// Uniformly sampled u16.
     /// May fail in rare circumstances or heavy load.
     #[inline]
-    pub fn get_u16(self) -> Option<u16> {
+    pub fn get_u16(&self) -> Option<u16> {
         let mut res: u16 = 0;
         unsafe {
             match core::arch::x86_64::_rdrand16_step(&mut res) {

src/structures/gdt.rs

@@ -27,13 +27,13 @@ impl SegmentSelector {
 
     /// Returns the GDT index.
     #[inline]
-    pub fn index(self) -> u16 {
+    pub fn index(&self) -> u16 {
         self.0 >> 3
     }
 
     /// Returns the requested privilege level.
     #[inline]
-    pub fn rpl(self) -> PrivilegeLevel {
+    pub fn rpl(&self) -> PrivilegeLevel {
         PrivilegeLevel::from_u16(self.0.get_bits(0..2))
     }
 

src/structures/paging/frame.rs

@@ -37,13 +37,13 @@ impl<S: PageSize> PhysFrame<S> {
 
     /// Returns the start address of the frame.
     #[inline]
-    pub fn start_address(self) -> PhysAddr {
+    pub fn start_address(&self) -> PhysAddr {
         self.start_address
     }
 
     /// Returns the size the frame (4KB, 2MB or 1GB).
     #[inline]
-    pub fn size(self) -> u64 {
+    pub fn size(&self) -> u64 {
         S::SIZE
     }
 

src/structures/paging/page.rs

@@ -85,14 +85,14 @@ impl<S: PageSize> Page<S> {
 
     /// Returns the start address of the page.
     #[inline]
-    pub fn start_address(self) -> VirtAddr {
+    pub fn start_address(&self) -> VirtAddr {
         self.start_address
     }
 
     /// Returns the size the page (4KB, 2MB or 1GB).
     #[cfg(feature = "const_fn")]
     #[inline]
-    pub const fn size(self) -> u64 {
+    pub const fn size(&self) -> u64 {
         S::SIZE
     }
 
@@ -105,13 +105,13 @@ impl<S: PageSize> Page<S> {
 
     /// Returns the level 4 page table index of this page.
     #[inline]
-    pub fn p4_index(self) -> PageTableIndex {
+    pub fn p4_index(&self) -> PageTableIndex {
         self.start_address().p4_index()
     }
 
     /// Returns the level 3 page table index of this page.
     #[inline]
-    pub fn p3_index(self) -> PageTableIndex {
+    pub fn p3_index(&self) -> PageTableIndex {
         self.start_address().p3_index()
     }
 
@@ -131,7 +131,7 @@ impl<S: PageSize> Page<S> {
 impl<S: NotGiantPageSize> Page<S> {
     /// Returns the level 2 page table index of this page.
     #[inline]
-    pub fn p2_index(self) -> PageTableIndex {
+    pub fn p2_index(&self) -> PageTableIndex {
         self.start_address().p2_index()
     }
 }
@@ -188,7 +188,7 @@ impl Page<Size4KiB> {
 
     /// Returns the level 1 page table index of this page.
     #[inline]
-    pub fn p1_index(self) -> PageTableIndex {
+    pub fn p1_index(&self) -> PageTableIndex {
         self.start_address().p1_index()
     }
 }