Skip to content

Commit f7f57fc

Browse files
committed
Fix some review comments
1 parent abdf5a6 commit f7f57fc

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

functional/generics-type-classes.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -204,21 +204,23 @@ Second, it makes the `impl` blocks easier to read, because they are broken down
204204
by state. Methods common to all states are typed once in one block, and methods
205205
unique to one state are in a separate block.
206206

207-
Both of these mean there is less code and it is better organized.
207+
Both of these mean there are fewer lines of code and it is better organized.
208208

209209
## Disadvantages
210210

211-
This increases code size. Hopefully the compiler will be more intelligent about
212-
the way monomorphization is implemented in the future.
211+
This current increases the size of the binary, due to the way monomorphization
212+
is implemented in the compiler. Hopefully the implementation will be able to
213+
improve in the future.
213214

214215
## Alternatives
215216

216-
If a type seems to need a "split API" due to construction or partial
217+
* If a type seems to need a "split API" due to construction or partial
217218
initialization, consider the
218219
[Builder Pattern](../patterns/creational/builder.md) instead.
219220

220-
If the API between types does not change -- only the behavior does -- then the
221-
[Strategy Pattern](../patterns/behavioural/strategy.md) is better used instead.
221+
* If the API between types does not change -- only the behavior does -- then
222+
the [Strategy Pattern](../patterns/behavioural/strategy.md) is better used
223+
instead.
222224

223225
## See also
224226

0 commit comments

Comments
 (0)