Skip to content

Commit 1efa724

Browse files
Sergii Glushchenkoandreeaflorescu
authored andcommitted
Fix warnings and adjust test coverage
Signed-off-by: Sergii Glushchenko <[email protected]>
1 parent 941b77e commit 1efa724

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

coverage_config_x86_64.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"coverage_score": 87.0,
2+
"coverage_score": 85.6,
33
"exclude_path": "tests/,benches/,utilities/",
44
"crate_features": "remote_endpoint,test_utilities"
55
}

src/manager.rs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -384,14 +384,14 @@ mod tests {
384384
// When running the loop the first time, ev1 should be processed, but ev2 shouldn't
385385
// because it was just added as part of processing ev1.
386386
event_manager.run().unwrap();
387-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev1_out(), true);
388-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev2_out(), false);
387+
assert!(dummy_subscriber.lock().unwrap().processed_ev1_out());
388+
assert!(!dummy_subscriber.lock().unwrap().processed_ev2_out());
389389

390390
// Check that both ev1 and ev2 are processed.
391391
dummy_subscriber.lock().unwrap().reset_state();
392392
event_manager.run().unwrap();
393-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev1_out(), true);
394-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev2_out(), true);
393+
assert!(dummy_subscriber.lock().unwrap().processed_ev1_out());
394+
assert!(dummy_subscriber.lock().unwrap().processed_ev2_out());
395395
}
396396

397397
#[test]
@@ -416,13 +416,13 @@ mod tests {
416416
dummy_subscriber.lock().unwrap().unregister_ev1();
417417

418418
event_manager.run().unwrap();
419-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev1_out(), true);
419+
assert!(dummy_subscriber.lock().unwrap().processed_ev1_out());
420420

421421
dummy_subscriber.lock().unwrap().reset_state();
422422

423423
// We expect no events to be available. Let's run with timeout so that run exists.
424424
event_manager.run_with_timeout(100).unwrap();
425-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev1_out(), false);
425+
assert!(!dummy_subscriber.lock().unwrap().processed_ev1_out());
426426
}
427427

428428
#[test]
@@ -435,8 +435,8 @@ mod tests {
435435
// Modify ev1 so that it waits for EPOLL_IN.
436436
dummy_subscriber.lock().unwrap().modify_ev1();
437437
event_manager.run().unwrap();
438-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev1_out(), true);
439-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev2_out(), false);
438+
assert!(dummy_subscriber.lock().unwrap().processed_ev1_out());
439+
assert!(!dummy_subscriber.lock().unwrap().processed_ev2_out());
440440

441441
dummy_subscriber.lock().unwrap().reset_state();
442442

@@ -449,9 +449,9 @@ mod tests {
449449
.unwrap();
450450

451451
event_manager.run().unwrap();
452-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev1_out(), false);
453-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev2_out(), false);
454-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev1_in(), true);
452+
assert!(!dummy_subscriber.lock().unwrap().processed_ev1_out());
453+
assert!(!dummy_subscriber.lock().unwrap().processed_ev2_out());
454+
assert!(dummy_subscriber.lock().unwrap().processed_ev1_in());
455455
}
456456

457457
#[test]
@@ -461,15 +461,15 @@ mod tests {
461461

462462
let subscriber_id = event_manager.add_subscriber(dummy_subscriber.clone());
463463
event_manager.run().unwrap();
464-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev1_out(), true);
464+
assert!(dummy_subscriber.lock().unwrap().processed_ev1_out());
465465

466466
dummy_subscriber.lock().unwrap().reset_state();
467467

468468
event_manager.remove_subscriber(subscriber_id).unwrap();
469469

470470
// We expect no events to be available. Let's run with timeout so that run exits.
471471
event_manager.run_with_timeout(100).unwrap();
472-
assert_eq!(dummy_subscriber.lock().unwrap().processed_ev1_out(), false);
472+
assert!(!dummy_subscriber.lock().unwrap().processed_ev1_out());
473473

474474
// Removing the subscriber twice should return an error.
475475
assert_eq!(

0 commit comments

Comments
 (0)