Remove TODO-comment about safety of casting ptr to *mut u8

ludfjig · ludfjig · commit 18358dc5e34a · 2025-11-18T10:07:42.000-08:00
Signed-off-by: Ludvig Liljenberg &lt;4257730+ludfjig@users.noreply.github.com&gt;
diff --git a/kvm-ioctls/src/ioctls/vm.rs b/kvm-ioctls/src/ioctls/vm.rs
@@ -668,7 +668,7 @@ impl VmFd {
             dst.flags = src.flags.bits();
             dst.nmsrs = src.msr_count;
             dst.base = src.base;
-            dst.bitmap = src.bitmap.as_ptr() as *mut u8; // TODO: is this cast ok? kvm_msr_filter_range.bitmap is __*mut__ u8. Ideally I don't want to require input parameters to be mutable unless it's necessary
+            dst.bitmap = src.bitmap.as_ptr() as *mut u8; // The ioctl doesn't modify the bitmap, so this cast is safe.
         }
 
         // SAFETY: We checked the length of all bitmaps above.

Original file line number	Diff line number	Diff line change
`@@ -668,7 +668,7 @@ impl VmFd {`
`668`	`668`	`dst.flags = src.flags.bits();`
`669`	`669`	`dst.nmsrs = src.msr_count;`
`670`	`670`	`dst.base = src.base;`
`671`		`- dst.bitmap = src.bitmap.as_ptr() as mut u8; // TODO: is this cast ok? kvm_msr_filter_range.bitmap is __mut__ u8. Ideally I don't want to require input parameters to be mutable unless it's necessary`
	`671`	`+ dst.bitmap = src.bitmap.as_ptr() as *mut u8; // The ioctl doesn't modify the bitmap, so this cast is safe.`
`672`	`672`	`}`
`673`	`673`
`674`	`674`	`// SAFETY: We checked the length of all bitmaps above.`