chore: address new #[must_use] warning on into_raw_fd

roypat · roypat · commit 1de9229fb5f1 · 2025-01-06T16:13:31.000Z
We explicitly use into_raw_fd to leak an already closed fd.

Signed-off-by: Patrick Roy &lt;roypat@amazon.co.uk&gt;
diff --git a/kvm-ioctls/src/ioctls/vcpu.rs b/kvm-ioctls/src/ioctls/vcpu.rs
@@ -2863,7 +2863,7 @@ mod tests {
 
         // Don't drop the File object, or it'll notice the file it's trying to close is
         // invalid and abort the process.
-        faulty_vcpu_fd.vcpu.into_raw_fd();
+        let _ = faulty_vcpu_fd.vcpu.into_raw_fd();
     }
 
     #[test]
@@ -2909,7 +2909,7 @@ mod tests {
 
         // Don't drop the File object, or it'll notice the file it's trying to close is
         // invalid and abort the process.
-        faulty_vcpu_fd.vcpu.into_raw_fd();
+        let _ = faulty_vcpu_fd.vcpu.into_raw_fd();
     }
 
     #[test]

Original file line number	Diff line number	Diff line change
`@@ -2863,7 +2863,7 @@ mod tests {`
`2863`	`2863`
`2864`	`2864`	`// Don't drop the File object, or it'll notice the file it's trying to close is`
`2865`	`2865`	`// invalid and abort the process.`
`2866`		`- faulty_vcpu_fd.vcpu.into_raw_fd();`
	`2866`	`+ let _ = faulty_vcpu_fd.vcpu.into_raw_fd();`
`2867`	`2867`	`}`
`2868`	`2868`
`2869`	`2869`	`#[test]`
`@@ -2909,7 +2909,7 @@ mod tests {`
`2909`	`2909`
`2910`	`2910`	`// Don't drop the File object, or it'll notice the file it's trying to close is`
`2911`	`2911`	`// invalid and abort the process.`
`2912`		`- faulty_vcpu_fd.vcpu.into_raw_fd();`
	`2912`	`+ let _ = faulty_vcpu_fd.vcpu.into_raw_fd();`
`2913`	`2913`	`}`
`2914`	`2914`
`2915`	`2915`	`#[test]`