clippy: more fixes

Signed-off-by: Philipp Schuster <[email protected]>
On-behalf-of: SAP [email protected]

Author: phip1611

kvm-bindings/src/lib.rs

@@ -6,6 +6,7 @@
 #![allow(non_upper_case_globals)]
 #![allow(non_camel_case_types)]
 #![allow(non_snake_case)]
+#![deny(clippy::undocumented_unsafe_blocks)]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 
 #[cfg(feature = "fam-wrappers")]

kvm-ioctls/src/ioctls/device.rs

@@ -192,6 +192,7 @@ impl FromRawFd for DeviceFd {
     /// that relies on it being true.
     unsafe fn from_raw_fd(fd: RawFd) -> Self {
         DeviceFd {
+            // SAFETY: we trust the kernel and verified parameters
             fd: unsafe { File::from_raw_fd(fd) },
         }
     }

kvm-ioctls/src/ioctls/system.rs

@@ -672,6 +672,7 @@ impl Kvm {
     /// ```
     pub unsafe fn create_vmfd_from_rawfd(&self, fd: RawFd) -> Result<VmFd> {
         let run_mmap_size = self.get_vcpu_mmap_size()?;
+        // SAFETY: we trust the kernel and verified parameters
         Ok(new_vmfd(unsafe { File::from_raw_fd(fd) }, run_mmap_size))
     }
 }
@@ -712,6 +713,7 @@ impl FromRawFd for Kvm {
     /// ```
     unsafe fn from_raw_fd(fd: RawFd) -> Self {
         Kvm {
+            // SAFETY: we trust the kernel and verified parameters
             kvm: unsafe { File::from_raw_fd(fd) },
         }
     }

kvm-ioctls/src/ioctls/vcpu.rs

@@ -1024,6 +1024,7 @@ impl VcpuFd {
     /// ```
     #[cfg(target_arch = "x86_64")]
     pub unsafe fn set_xsave2(&self, xsave: &Xsave) -> Result<()> {
+        // SAFETY: we trust the kernel and verified parameters
         unsafe { self.set_xsave(&xsave.as_fam_struct_ref().xsave) }
     }
 

kvm-ioctls/src/ioctls/vm.rs

@@ -107,6 +107,7 @@ impl VmFd {
         &self,
         user_memory_region: kvm_userspace_memory_region,
     ) -> Result<()> {
+        // SAFETY: we trust the kernel and verified parameters
         let ret =
             unsafe { ioctl_with_ref(self, KVM_SET_USER_MEMORY_REGION(), &user_memory_region) };
         if ret == 0 {
@@ -194,6 +195,7 @@ impl VmFd {
         &self,
         user_memory_region2: kvm_userspace_memory_region2,
     ) -> Result<()> {
+        // SAFETY: we trust the kernel and verified parameters
         let ret =
             unsafe { ioctl_with_ref(self, KVM_SET_USER_MEMORY_REGION2(), &user_memory_region2) };
         if ret == 0 {
@@ -1245,6 +1247,7 @@ impl VmFd {
     /// let vcpu = unsafe { vm.create_vcpu_from_rawfd(rawfd).unwrap() };
     /// ```
     pub unsafe fn create_vcpu_from_rawfd(&self, fd: RawFd) -> Result<VcpuFd> {
+        // SAFETY: we trust the kernel and verified parameters
         let vcpu = unsafe { File::from_raw_fd(fd) };
         let kvm_run_ptr = KvmRunWrapper::mmap_from_fd(&vcpu, self.run_size)?;
         Ok(new_vcpu(vcpu, kvm_run_ptr))
@@ -1650,6 +1653,7 @@ impl VmFd {
     /// ```
     #[cfg(target_arch = "x86_64")]
     pub unsafe fn encrypt_op<T>(&self, op: *mut T) -> Result<()> {
+        // SAFETY: we trust the kernel and verified parameters
         let ret = unsafe { ioctl_with_mut_ptr(self, KVM_MEMORY_ENCRYPT_OP(), op) };
         if ret == 0 {
             Ok(())

kvm-ioctls/src/lib.rs

@@ -9,6 +9,7 @@
 #![deny(missing_docs)]
 #![deny(missing_copy_implementations)]
 #![deny(missing_debug_implementations)]
+#![deny(clippy::undocumented_unsafe_blocks)]
 #![warn(clippy::assertions_on_result_states)]
 
 //! A safe wrapper around the kernel's KVM interface.