Skip to content

Commit eff204c

Browse files
committed
clippy: Fix precedence clippy warning
Fix `precedence` clippy warning reported by rustc 1.85.0 (4d91de4e4 2025-02-17): error: operator precedence can trip the unwary --> vfio-user/examples/gpio/pci.rs:340:24 | 340 | registers[0] = u32::from(device_id) << 16 | u32::from(vendor_id); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(u32::from(device_id) << 16) | u32::from(vendor_id)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence = note: `-D clippy::precedence` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::precedence)]` Signed-off-by: Ruoqing He <[email protected]>
1 parent 985d214 commit eff204c

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

vfio-user/examples/gpio/pci.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -337,24 +337,24 @@ impl PciConfiguration {
337337
) -> Self {
338338
let mut registers = [0u32; NUM_CONFIGURATION_REGISTERS];
339339
let mut writable_bits = [0u32; NUM_CONFIGURATION_REGISTERS];
340-
registers[0] = u32::from(device_id) << 16 | u32::from(vendor_id);
340+
registers[0] = (u32::from(device_id) << 16) | u32::from(vendor_id);
341341
// TODO(dverkamp): Status should be write-1-to-clear
342342
writable_bits[1] = 0x0000_ffff; // Status (r/o), command (r/w)
343343
let pi = if let Some(pi) = programming_interface {
344344
pi.get_register_value()
345345
} else {
346346
0
347347
};
348-
registers[2] = u32::from(class_code.get_register_value()) << 24
349-
| u32::from(subclass.get_register_value()) << 16
350-
| u32::from(pi) << 8
348+
registers[2] = (u32::from(class_code.get_register_value()) << 24)
349+
| (u32::from(subclass.get_register_value()) << 16)
350+
| (u32::from(pi) << 8)
351351
| u32::from(revision_id);
352352
writable_bits[3] = 0x0000_00ff; // Cacheline size (r/w)
353353
match header_type {
354354
PciHeaderType::Device => {
355355
registers[3] = 0x0000_0000; // Header type 0 (device)
356356
writable_bits[15] = 0x0000_00ff; // Interrupt line (r/w)
357-
registers[11] = u32::from(subsystem_id) << 16 | u32::from(subsystem_vendor_id);
357+
registers[11] = (u32::from(subsystem_id) << 16) | u32::from(subsystem_vendor_id);
358358
}
359359
PciHeaderType::Bridge => {
360360
registers[3] = 0x0001_0000; // Header type 1 (bridge)
@@ -608,7 +608,7 @@ impl PciConfiguration {
608608
}
609609
PciBarRegionType::Memory64BitRegion => {
610610
u64::from(self.registers[bar_idx] & BAR_MEM_ADDR_MASK)
611-
| u64::from(self.registers[bar_idx + 1]) << 32
611+
| (u64::from(self.registers[bar_idx + 1]) << 32)
612612
}
613613
}
614614
}

0 commit comments

Comments
 (0)