@@ -337,24 +337,24 @@ impl PciConfiguration {
337
337
) -> Self {
338
338
let mut registers = [ 0u32 ; NUM_CONFIGURATION_REGISTERS ] ;
339
339
let mut writable_bits = [ 0u32 ; NUM_CONFIGURATION_REGISTERS ] ;
340
- registers[ 0 ] = u32:: from ( device_id) << 16 | u32:: from ( vendor_id) ;
340
+ registers[ 0 ] = ( u32:: from ( device_id) << 16 ) | u32:: from ( vendor_id) ;
341
341
// TODO(dverkamp): Status should be write-1-to-clear
342
342
writable_bits[ 1 ] = 0x0000_ffff ; // Status (r/o), command (r/w)
343
343
let pi = if let Some ( pi) = programming_interface {
344
344
pi. get_register_value ( )
345
345
} else {
346
346
0
347
347
} ;
348
- registers[ 2 ] = u32:: from ( class_code. get_register_value ( ) ) << 24
349
- | u32:: from ( subclass. get_register_value ( ) ) << 16
350
- | u32:: from ( pi) << 8
348
+ registers[ 2 ] = ( u32:: from ( class_code. get_register_value ( ) ) << 24 )
349
+ | ( u32:: from ( subclass. get_register_value ( ) ) << 16 )
350
+ | ( u32:: from ( pi) << 8 )
351
351
| u32:: from ( revision_id) ;
352
352
writable_bits[ 3 ] = 0x0000_00ff ; // Cacheline size (r/w)
353
353
match header_type {
354
354
PciHeaderType :: Device => {
355
355
registers[ 3 ] = 0x0000_0000 ; // Header type 0 (device)
356
356
writable_bits[ 15 ] = 0x0000_00ff ; // Interrupt line (r/w)
357
- registers[ 11 ] = u32:: from ( subsystem_id) << 16 | u32:: from ( subsystem_vendor_id) ;
357
+ registers[ 11 ] = ( u32:: from ( subsystem_id) << 16 ) | u32:: from ( subsystem_vendor_id) ;
358
358
}
359
359
PciHeaderType :: Bridge => {
360
360
registers[ 3 ] = 0x0001_0000 ; // Header type 1 (bridge)
@@ -608,7 +608,7 @@ impl PciConfiguration {
608
608
}
609
609
PciBarRegionType :: Memory64BitRegion => {
610
610
u64:: from ( self . registers [ bar_idx] & BAR_MEM_ADDR_MASK )
611
- | u64:: from ( self . registers [ bar_idx + 1 ] ) << 32
611
+ | ( u64:: from ( self . registers [ bar_idx + 1 ] ) << 32 )
612
612
}
613
613
}
614
614
}
0 commit comments