Skip to content

Commit e91563e

Browse files
vireshkandreeaflorescu
authored andcommitted
vsock: Migrate to ptr_guard() for volatile slice
`as_ptr()` is deprecated now and users must use `ptr_guard()` instead. Migrate to that. Signed-off-by: Viresh Kumar <[email protected]>
1 parent 1f2dd43 commit e91563e

File tree

1 file changed

+21
-12
lines changed

1 file changed

+21
-12
lines changed

crates/devices/virtio-vsock/src/packet.rs

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -878,14 +878,14 @@ mod tests {
878878
assert_eq!(packet.header, PacketHeader::default());
879879
let header = packet.header_slice();
880880
assert_eq!(
881-
header.as_ptr(),
881+
header.ptr_guard().as_ptr(),
882882
mem.get_host_address(GuestAddress(0x5_0000)).unwrap()
883883
);
884884
assert_eq!(header.len(), PKT_HEADER_SIZE);
885885

886886
let data = packet.data_slice().unwrap();
887887
assert_eq!(
888-
data.as_ptr(),
888+
data.ptr_guard().as_ptr(),
889889
mem.get_host_address(GuestAddress(0x8_0000)).unwrap()
890890
);
891891
assert_eq!(data.len(), 0x100);
@@ -911,14 +911,14 @@ mod tests {
911911
assert_eq!(packet.header, PacketHeader::default());
912912
let header = packet.header_slice();
913913
assert_eq!(
914-
header.as_ptr(),
914+
header.ptr_guard().as_ptr(),
915915
mem.get_host_address(GuestAddress(0x5_0000)).unwrap()
916916
);
917917
assert_eq!(header.len(), PKT_HEADER_SIZE);
918918

919919
let data = packet.data_slice().unwrap();
920920
assert_eq!(
921-
data.as_ptr(),
921+
data.ptr_guard().as_ptr(),
922922
mem.get_host_address(GuestAddress(0x5_0000 + PKT_HEADER_SIZE as u64))
923923
.unwrap()
924924
);
@@ -976,7 +976,7 @@ mod tests {
976976
assert_eq!(packet.header, header);
977977
let header_slice = packet.header_slice();
978978
assert_eq!(
979-
header_slice.as_ptr(),
979+
header_slice.ptr_guard().as_ptr(),
980980
mem.get_host_address(GuestAddress(0x10_0000)).unwrap()
981981
);
982982
assert_eq!(header_slice.len(), PKT_HEADER_SIZE);
@@ -1116,7 +1116,7 @@ mod tests {
11161116
assert_eq!(packet.header, header);
11171117
let header_slice = packet.header_slice();
11181118
assert_eq!(
1119-
header_slice.as_ptr(),
1119+
header_slice.ptr_guard().as_ptr(),
11201120
mem.get_host_address(GuestAddress(0x5_0000)).unwrap()
11211121
);
11221122
assert_eq!(header_slice.len(), PKT_HEADER_SIZE);
@@ -1125,7 +1125,7 @@ mod tests {
11251125

11261126
let data = packet.data_slice().unwrap();
11271127
assert_eq!(
1128-
data.as_ptr(),
1128+
data.ptr_guard().as_ptr(),
11291129
mem.get_host_address(GuestAddress(0x8_0000)).unwrap()
11301130
);
11311131
assert_eq!(data.len(), LEN as usize);
@@ -1151,7 +1151,7 @@ mod tests {
11511151
assert_eq!(packet.header, header);
11521152
let header_slice = packet.header_slice();
11531153
assert_eq!(
1154-
header_slice.as_ptr(),
1154+
header_slice.ptr_guard().as_ptr(),
11551155
mem.get_host_address(GuestAddress(0x5_0000)).unwrap()
11561156
);
11571157
assert_eq!(header_slice.len(), PKT_HEADER_SIZE);
@@ -1160,7 +1160,7 @@ mod tests {
11601160

11611161
let data = packet.data_slice().unwrap();
11621162
assert_eq!(
1163-
data.as_ptr(),
1163+
data.ptr_guard().as_ptr(),
11641164
mem.get_host_address(GuestAddress(0x5_0000 + PKT_HEADER_SIZE as u64))
11651165
.unwrap()
11661166
);
@@ -1346,16 +1346,25 @@ mod tests {
13461346
// SAFETY: safe because ``hdr_raw` and `data_raw` live for as long as
13471347
// the scope of the current test.
13481348
let packet = unsafe { VsockPacket::new(hdr_raw, Some(data_raw)).unwrap() };
1349-
assert_eq!(packet.header_slice.as_ptr(), hdr_raw.as_mut_ptr());
1349+
assert_eq!(
1350+
packet.header_slice.ptr_guard().as_ptr(),
1351+
hdr_raw.as_mut_ptr(),
1352+
);
13501353
assert_eq!(packet.header_slice.len(), PKT_HEADER_SIZE);
13511354
assert_eq!(packet.header, PacketHeader::default());
1352-
assert_eq!(packet.data_slice.unwrap().as_ptr(), data_raw.as_mut_ptr());
1355+
assert_eq!(
1356+
packet.data_slice.unwrap().ptr_guard().as_ptr(),
1357+
data_raw.as_mut_ptr(),
1358+
);
13531359
assert_eq!(packet.data_slice.unwrap().len(), LEN as usize);
13541360

13551361
// SAFETY: Safe because ``hdr_raw` and `data_raw` live as long as the
13561362
// scope of the current test.
13571363
let packet = unsafe { VsockPacket::new(hdr_raw, None).unwrap() };
1358-
assert_eq!(packet.header_slice.as_ptr(), hdr_raw.as_mut_ptr());
1364+
assert_eq!(
1365+
packet.header_slice.ptr_guard().as_ptr(),
1366+
hdr_raw.as_mut_ptr(),
1367+
);
13591368
assert_eq!(packet.header, PacketHeader::default());
13601369
assert!(packet.data_slice.is_none());
13611370

0 commit comments

Comments
 (0)