Skip to content

Commit 53ccc11

Browse files
committed
Make Buffer::width/height return u32 instead of NonZeroU32
1 parent f0a809c commit 53ccc11

File tree

16 files changed

+65
-49
lines changed

16 files changed

+65
-49
lines changed

examples/animation.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ fn main() {
6262

6363
let mut buffer = surface.buffer_mut().unwrap();
6464

65-
let size = (buffer.width().get(), buffer.height().get());
65+
let size = (buffer.width(), buffer.height());
6666
if size != *old_size {
6767
*old_size = size;
6868
*frames = pre_render_frames(size.0, size.1);

examples/rectangle.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ use winit::keyboard::{Key, NamedKey};
88
mod util;
99

1010
fn redraw(buffer: &mut Buffer<'_, impl HasDisplayHandle, impl HasWindowHandle>, flag: bool) {
11-
let width = buffer.width().get();
12-
let height = buffer.height().get();
11+
let width = buffer.width();
12+
let height = buffer.height();
1313
for y in 0..height {
1414
for x in 0..width {
1515
let value = if flag && x >= 100 && x < width - 100 && y >= 100 && y < height - 100 {

examples/winit.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,12 @@ pub(crate) fn entry(event_loop: EventLoop<()>) {
4646
};
4747

4848
let mut buffer = surface.buffer_mut().unwrap();
49-
for y in 0..buffer.height().get() {
50-
for x in 0..buffer.width().get() {
49+
for y in 0..buffer.height() {
50+
for x in 0..buffer.width() {
5151
let red = x % 255;
5252
let green = y % 255;
5353
let blue = (x * y) % 255;
54-
let index = y * buffer.width().get() + x;
54+
let index = y * buffer.width() + x;
5555
buffer[index as usize] = blue | (green << 8) | (red << 16);
5656
}
5757
}

examples/winit_multithread.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ pub mod ex {
3232
surface.resize(width, height).unwrap();
3333

3434
let mut buffer = surface.buffer_mut().unwrap();
35-
for y in 0..buffer.height().get() {
36-
for x in 0..buffer.width().get() {
35+
for y in 0..buffer.height() {
36+
for x in 0..buffer.width() {
3737
let red = x % 255;
3838
let green = y % 255;
3939
let blue = (x * y) % 255;
40-
let index = y * buffer.width().get() + x;
40+
let index = y * buffer.width() + x;
4141
buffer[index as usize] = blue | (green << 8) | (red << 16);
4242
}
4343
}

examples/winit_wrong_sized_buffer.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ fn main() {
3737
};
3838

3939
let mut buffer = surface.buffer_mut().unwrap();
40-
let width = buffer.width().get();
41-
for y in 0..buffer.height().get() {
40+
let width = buffer.width();
41+
for y in 0..buffer.height() {
4242
for x in 0..width {
4343
let red = x % 255;
4444
let green = y % 255;

src/backend_dispatch.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ macro_rules! make_dispatch {
147147

148148
impl<'a, D: HasDisplayHandle, W: HasWindowHandle> BufferInterface for BufferDispatch<'a, D, W> {
149149
#[inline]
150-
fn width(&self) -> NonZeroU32 {
150+
fn width(&self) -> u32 {
151151
match self {
152152
$(
153153
$(#[$attr])*
@@ -157,7 +157,7 @@ macro_rules! make_dispatch {
157157
}
158158

159159
#[inline]
160-
fn height(&self) -> NonZeroU32 {
160+
fn height(&self) -> u32 {
161161
match self {
162162
$(
163163
$(#[$attr])*

src/backend_interface.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ pub(crate) trait SurfaceInterface<D: HasDisplayHandle + ?Sized, W: HasWindowHand
3535
}
3636

3737
pub(crate) trait BufferInterface {
38-
fn width(&self) -> NonZeroU32;
39-
fn height(&self) -> NonZeroU32;
38+
fn width(&self) -> u32;
39+
fn height(&self) -> u32;
4040
fn pixels(&self) -> &[u32];
4141
fn pixels_mut(&mut self) -> &mut [u32];
4242
fn age(&self) -> u8;

src/backends/android.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,12 @@ pub struct BufferImpl<'a, D: ?Sized, W> {
125125
unsafe impl<'a, D, W> Send for BufferImpl<'a, D, W> {}
126126

127127
impl<'a, D: HasDisplayHandle, W: HasWindowHandle> BufferInterface for BufferImpl<'a, D, W> {
128-
fn width(&self) -> NonZeroU32 {
129-
NonZeroU32::new(self.native_window_buffer.width() as u32).unwrap()
128+
fn width(&self) -> u32 {
129+
self.native_window_buffer.width() as u32
130130
}
131131

132-
fn height(&self) -> NonZeroU32 {
133-
NonZeroU32::new(self.native_window_buffer.height() as u32).unwrap()
132+
fn height(&self) -> u32 {
133+
self.native_window_buffer.height() as u32
134134
}
135135

136136
#[inline]

src/backends/cg.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,12 +273,12 @@ pub struct BufferImpl<'a, D, W> {
273273
}
274274

275275
impl<D: HasDisplayHandle, W: HasWindowHandle> BufferInterface for BufferImpl<'_, D, W> {
276-
fn width(&self) -> NonZeroU32 {
277-
NonZeroU32::new(self.imp.width as u32).unwrap()
276+
fn width(&self) -> u32 {
277+
self.imp.width as u32
278278
}
279279

280-
fn height(&self) -> NonZeroU32 {
281-
NonZeroU32::new(self.imp.height as u32).unwrap()
280+
fn height(&self) -> u32 {
281+
self.imp.height as u32
282282
}
283283

284284
#[inline]

src/backends/kms.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,12 +301,12 @@ impl<D: ?Sized, W: ?Sized> Drop for KmsImpl<D, W> {
301301
}
302302

303303
impl<D: ?Sized, W: ?Sized> BufferInterface for BufferImpl<'_, D, W> {
304-
fn width(&self) -> NonZeroU32 {
305-
self.size.0
304+
fn width(&self) -> u32 {
305+
self.size.0.get()
306306
}
307307

308-
fn height(&self) -> NonZeroU32 {
309-
self.size.1
308+
fn height(&self) -> u32 {
309+
self.size.1.get()
310310
}
311311

312312
#[inline]

0 commit comments

Comments
 (0)