Skip to content

Commit 1c5f08b

Browse files
committed
[lp] review minor fixes
1 parent ec7970c commit 1c5f08b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

print/lp.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
use std::env;
1111
use std::fs::File;
1212
use std::io::{self, Cursor, Read};
13-
use std::path::PathBuf;
13+
use std::path::{Path, PathBuf};
1414
use std::process::ExitCode;
1515

1616
use clap::Parser;
@@ -94,7 +94,7 @@ fn validate_uri(dest: &str) -> Result<Uri, String> {
9494

9595
/// Read input data from a file or stdin.
9696
/// Note: Copy mode (-c) is effectively always-on since IPP requires full data upload.
97-
fn read_input(path: &PathBuf) -> Result<Vec<u8>, io::Error> {
97+
fn read_input(path: &Path) -> Result<Vec<u8>, io::Error> {
9898
let path_str = path.to_string_lossy();
9999
if path_str == "-" {
100100
let mut data = Vec::new();
@@ -199,7 +199,7 @@ fn send_print_job(
199199
Ok(job_id)
200200
}
201201

202-
fn do_lp(args: Args) -> Result<(), String> {
202+
fn do_lp(mut args: Args) -> Result<(), String> {
203203
// Get and validate destination
204204
let dest = get_destination(&args)?;
205205
let uri = validate_uri(&dest)?;
@@ -208,7 +208,7 @@ fn do_lp(args: Args) -> Result<(), String> {
208208
let files: Vec<PathBuf> = if args.files.is_empty() {
209209
vec![PathBuf::from("-")]
210210
} else {
211-
args.files.clone()
211+
std::mem::take(&mut args.files)
212212
};
213213

214214
// Process each file

0 commit comments

Comments
 (0)