Skip to content

Commit 05bea75

Browse files
committed
Remove unrelated_chain_valid_for_unrelated_domain test
Going forwards we will just use another pre-existing chain for unrelated name tests to reduce the maintainence burden. Given that, we don't need to keep this chain around or test that its valid for itself anymore.
1 parent eb80998 commit 05bea75

File tree

5 files changed

+2
-18
lines changed

5 files changed

+2
-18
lines changed

rustls-platform-verifier/src/tests/verification_real_world/mod.rs

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,8 @@ const VALID_1PASSWORD_COM_CHAIN: &[&[u8]] = &[
6767

6868
const MY_1PASSWORD_COM: &str = "my.1password.com";
6969

70-
// A domain name for which `VALID_1PASSWORD_COM_CHAIN` isn't valid.
71-
const VALID_UNRELATED_DOMAIN: &str = "agilebits.com";
72-
const VALID_UNRELATED_CHAIN: &[&[u8]] = &[
73-
include_bytes!("agilebits_com_valid_1.crt"),
74-
include_bytes!("agilebits_com_valid_2.crt"),
75-
include_bytes!("agilebits_com_valid_3.crt"),
76-
include_bytes!("agilebits_com_valid_4.crt"),
77-
];
70+
// A domain name for which `VALID_AWS_AMAZON_COM_CHAIN` isn't valid.
71+
const VALID_UNRELATED_DOMAIN: &str = "my.1password.com";
7872

7973
const LETSENCRYPT_ORG: &str = "letsencrypt.org";
8074

@@ -215,16 +209,6 @@ real_world_test_cases! {
215209
expected_result: Err(TlsError::InvalidCertificate(CertificateError::NotValidForName)),
216210
other_error: no_error!(),
217211
},
218-
// The certificate chain for the unrelated domain is valid for that
219-
// unrelated domain.
220-
unrelated_chain_valid_for_unrelated_domain => TestCase {
221-
reference_id: VALID_UNRELATED_DOMAIN,
222-
chain: VALID_UNRELATED_CHAIN,
223-
stapled_ocsp: None,
224-
verification_time: verification_time(),
225-
expected_result: Ok(()),
226-
other_error: no_error!(),
227-
},
228212
// The certificate chain for the unrelated domain is not valid for
229213
// my.1password.com.
230214
unrelated_chain_not_valid_for_my_1password_com => TestCase {

0 commit comments

Comments
 (0)