Skip to content

Add advisory for unsound problems in workflow-core #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add advisory for unsound problems in workflow-core #2001

wants to merge 2 commits into from

Conversation

safe4u
Copy link
Contributor

@safe4u safe4u commented Jul 7, 2024

The util functions buffer_as_slice and buffer_as_slice_mut in crate workflow-core could create illegal slice.
The details are described in workflow-rs/workflow-rs#11

@kornelski
Copy link
Contributor

kornelski commented Dec 4, 2024 •
edited
Loading

Still unsound in 0.18.0. Could you update the version in the advisory?

kornelski
kornelski suggested changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@kornelski kornelski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The report is technically accurate.

Sadly, there's no fixed version, and it looks like development on the crate has ground to a halt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kornelski kornelski kornelski approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@safe4u @kornelski