Skip to content

Conversation

@striezel
Copy link

(Note: This draft will probably get rebased after #3 has been merged, and it will probably get a changelog entry and a version bump, too.)

This pull requests attempts to:

  • resolve conflicts in dependencies (e. g. jest / ts-jest / @types/jest) that made a clean npm install impossible,
  • update most dependencies to get rid of the major security vulnerabilities, and
  • adjusts the GitHub Actions workflow to get around an error in the build step.

I am creating this PR so that any potential reviewers can get over the shock of having a PR with more than 10000 additions and deletions, and to give the opportunity to state whether you want me to split it into smaller PRs.

@striezel striezel marked this pull request as draft March 13, 2023 02:40
striezel added 29 commits March 13, 2023 23:41
This should have been done as part of rustsec#1.
Fixes CVE-2021-23362 (ReDoS vulnerability) in hosted-git-info.
Attempt to work around the

```
Error: error:0308010C:digital envelope routines::unsupported
[...]
ERR_OSSL_EVP_UNSUPPORTED
```

error in the build step.
Fixes CVE-2020-7774 (prototype pollution) in y18n.
Fixes CVE-2021-27290 (ReDoS vulnerability) in ssri.
Fixes CVE-2020-8203 (prototype pollution vulnerability) in lodash.
Fixes CVE-2020-7788 (prototype pollution vulnerability) in ini.
Fixes GHSA-jmqm-f2gx-4fjv (sensitive information exposure through
logs) in npm-registry-fetch.
Fixes CVE-2020-15228 (environment variable injection) in
@actions/core.
Fixes CVE-2021-3807 (ReDoS vulnerability) in ansi-regex.
Fixes CVE-2021-3777 (ReDoS vulnerability) in tmpl.
Fixes CVE-2022-24999 (prototype pollution) in qs.
Fixes CVE-2022-3517 (ReDoS vulnerability) in minimatch.
Fixes CVE-2022-46175 (prototype pollution) in json5.
Fixes CVE-2022-25881 (ReDoS vulnerability) in http-cache-semantics.
Fixes CVE-2021-44906 (prototype pollution) in minimist.
Fixes CVE-2021-23343 (ReDoS vulnerability) in path-parse.
@striezel striezel force-pushed the fix-dependency-hell branch from 24d8e08 to 9793f2f Compare March 13, 2023 22:42
@striezel striezel force-pushed the fix-dependency-hell branch from 9793f2f to 7d2839f Compare March 13, 2023 22:54
@striezel striezel marked this pull request as ready for review March 13, 2023 22:55
@striezel
Copy link
Author

Now that #3 has been merged, I made some minor adjustments (new version number, changelog) and this PR is ready for review.

@striezel striezel changed the title [Draft] Fix dependency conflicts, fix vulnerabilities / update dependencies Fix dependency conflicts, fix vulnerabilities / update dependencies Mar 13, 2023
@striezel striezel requested a review from pinkforest March 20, 2023 23:43
@striezel striezel mentioned this pull request Mar 26, 2023
@pinkforest pinkforest mentioned this pull request Mar 27, 2023
@pinkforest pinkforest closed this Mar 27, 2023
@pinkforest
Copy link

pinkforest commented Mar 27, 2023

I forked the actions-rs/core to rinse-repeat/actions-rs-core which I published to npmjs - now we don't need the token.
Since I didn't have permission to push to this branch I superceded this PR and I marked you as co-authored from these commits to the superceded PR.
It still needs a lot of work but anyways.
Cheers

@rustsec rustsec deleted a comment from striezel Mar 27, 2023
@rustsec rustsec locked as too heated and limited conversation to collaborators Mar 28, 2023
@rustsec rustsec deleted a comment from striezel Mar 28, 2023
@rustsec rustsec deleted a comment from striezel Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants