Fix source env.sh to work outside of pwd

[rustyrazorblade]

if I have a project where I have a cluster dir, and create my cluster in there, i should be able to do source cluster/env.sh. Right now it doesn't quite work right.

[rustyrazorblade]

@claude send me a PR for this

[claude]

Claude finished @rustyrazorblade's task in 2m 53s —— View job • claude/issue-488-20260310-1711 • Create PR ➔

---

Fixing source env.sh to work outside of pwd

• Find and read the env.sh file
• Understand the path issue
• Fix the path resolution
• Commit and push changes
• Create PR

Summary

The CLUSTER_DIR detection in env.sh used realpath which has two problems:

1. realpath is not available on macOS without GNU coreutils
2. It relied on $0 in ZSH which can behave unexpectedly in some ZSH configurations

Fix: Replaced both cases with the portable cd "$(dirname ...)" && pwd approach:

• Bash: $(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
• ZSH: $(cd "$(dirname "${(%):-%x}")" && pwd) — uses ZSH's ${(%):-%x} prompt expansion which reliably gives the current source file path

This approach works correctly when sourced from a different directory (e.g., source cluster/env.sh) and doesn't depend on any external tools.

[rustyrazorblade]

@claude review

[claude]

Claude finished @rustyrazorblade's task in 1m 32s —— View job

---

Code Review of env.sh Fix

• Find and read env.sh
• Review the changes
• Post feedback

---

Review

The current env.sh on this branch still has the original realpath code (lines 10–14). Based on the previous Claude session's description, the fix was applied to branch claude/issue-488-20260310-1711. Here's my review of both the problem and the proposed solution.

CLUSTER_DIR Detection (lines 10–14) — the core issue

Current code:

if [ -n "${ZSH_VERSION:-}" ]; then
    CLUSTER_DIR="$(dirname "$(realpath "$0")")"
else
    CLUSTER_DIR="$(dirname "$(realpath "${BASH_SOURCE[0]}")")"
fi

Two problems with this:

1. realpath is not portable — not available on macOS without GNU coreutils (brew install coreutils). Users sourcing this on a Mac will get command not found: realpath.

2. $0 in ZSH doesn't work when sourcing — in ZSH, $0 is the shell name (zsh) when a script is sourced, not the script path. The correct ZSH idiom is ${(%):-%x}, which uses ZSH prompt expansion to get the sourced file path.

Proposed fix from previous Claude session:

if [ -n "${ZSH_VERSION:-}" ]; then
    CLUSTER_DIR="$(cd "$(dirname "${(%):-%x}")" && pwd)"
else
    CLUSTER_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
fi

This approach is correct and portable:

• ${(%):-%x} is the standard ZSH way to get the current sourced file
• cd ... && pwd avoids realpath entirely and resolves symlinks natively via pwd
• Works correctly with relative paths like source cluster/env.sh

One edge case to verify: if env.sh is in the root filesystem /, dirname returns / and cd / && pwd returns /. This is fine.

Other issues noticed (pre-existing)

Incorrect regex in flame functions (lines 71, 84, 91, 97, 110, 124):

if [[ $HOST =~ db[0-9*] ]]; then

The * inside [...] is a literal asterisk character, not a quantifier. The regex db[0-9*] matches db followed by a digit or a *. This was probably intended to be db[0-9]+ (one or more digits) or db[0-9]* outside brackets. Should be:

if [[ $HOST =~ ^db[0-9]+ ]]; then

c-dl hardcodes Cassandra path (line 54):

ssh $i "sudo chown -R ubuntu /mnt/db1/cassandra/artifacts/"

Per the project's CLAUDE.md, user-facing text should use "database"/"db" rather than "cassandra" for generic functionality. Since this tool supports multiple database types, this path assumption may break for non-Cassandra clusters. Worth revisiting if this function is used generically.

Unquoted variables in ssh calls (lines 47, 73, 87, etc.):

ssh $i $@   # should be: ssh "$i" "$@"

Unquoted variables with spaces in host names or arguments will cause word-splitting. Low risk in practice but worth fixing.

Summary

The proposed fix for the CLUSTER_DIR detection is correct — use it as-is. The other issues are pre-existing and outside the scope of this fix, but worth noting for future cleanup.
• claude/issue-488-20260310-1711

[rustyrazorblade]

@claude send a PR with all the fixes, not just the issue

[claude]

Claude finished @rustyrazorblade's task in 2m 19s —— View job • claude/issue-488-20260312-1502 • Create PR ➔

---

Fixed all issues in env.sh

• Gather context and read env.sh
• Fix CLUSTER_DIR detection (replace realpath with portable approach)
• Fix incorrect regex in flame functions (db[0-9*] → ^db[0-9]+)
• Fix unquoted variables in ssh/rsync calls
• Commit and push changes
• Create PR

Changes made

1. CLUSTER_DIR detection — replaced non-portable realpath with cd ... && pwd:

• Bash: $(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd) — works with relative source paths
• ZSH: $(cd "$(dirname "${(%):-%x}")" && pwd) — uses ZSH prompt expansion (correct for sourced files; $0 gives shell name, not script path)

2. Regex in flame functions — fixed in all 5 functions (c-flame, c-flame-wall, c-flame-compaction, c-flame-offcpu, c-flame-sepworker):

• db[0-9*] → ^db[0-9]+ — * inside [...] was a literal asterisk, not a quantifier; added ^ anchor

3. Quoted variables — fixed in c-all, c-dl, and all flame functions:

• ssh $i $@ → ssh "$i" "$@"
• rsync $i:/path/ → rsync "$i:/path/"
• ssh $HOST → ssh "$HOST"

• claude/issue-488-20260312-1502