[fix] tests workflows

Author: rvalitov

.github/workflows/codacy.yml

@@ -22,7 +22,6 @@ permissions:
   contents: read
 
 env:
-  UBUNTU_VERSION: ubuntu-latest
   NODE_VERSION: latest
   PHP_VERSION: 8.3
   PHPUNIT_VERSION: 11
@@ -34,7 +33,7 @@ jobs:
       security-events: write # for github/codeql-action/upload-sarif to upload SARIF results
       actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status
     name: Codacy Security Scan
-    runs-on: ${{ env.UBUNTU_VERSION }}
+    runs-on: ubuntu-latest
     steps:
       # Checkout the repository to the GitHub Actions runner
       - name: Checkout code
@@ -64,7 +63,7 @@ jobs:
 
   codacy-coverage-reporter:
     name: Codacy Coverage Reporter
-    runs-on: ${{ env.UBUNTU_VERSION }}
+    runs-on: ubuntu-latest
     steps:
       - name: Setup PHP ${{ env.PHP_VERSION }}
         uses: shivammathur/setup-php@v2

.github/workflows/dependency-review.yml

@@ -5,19 +5,18 @@
 # Source repository: https://github.com/actions/dependency-review-action
 # Public documentation: https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review#dependency-review-enforcement
 name: "Dependency Review"
-on: [pull_request]
+on:
+  pull_request:
+    branches: ["master", "main"]
 
 permissions:
   contents: read
   pull-requests: write
 
-env:
-  UBUNTU_VERSION: ubuntu-latest
-
 jobs:
   dependency-review:
     name: Dependency Review
-    runs-on: ${{ env.UBUNTU_VERSION }}
+    runs-on: ubuntu-latest
     steps:
       - name: "Checkout Repository"
         uses: actions/checkout@v4

.github/workflows/devskim.yml

@@ -15,13 +15,10 @@ on:
   # eslint-disable-next-line yml/no-empty-mapping-value
   workflow_dispatch:
 
-env:
-  UBUNTU_VERSION: ubuntu-latest
-
 jobs:
   lint:
     name: DevSkim
-    runs-on: ${{ env.UBUNTU_VERSION }}
+    runs-on: ubuntu-latest
     permissions:
       actions: read
       contents: read

.github/workflows/sonarcloud.yml

@@ -19,15 +19,14 @@ permissions:
   pull-requests: read # allows SonarCloud to decorate PRs with analysis results
 
 env:
-  UBUNTU_VERSION: ubuntu-latest
   NODE_VERSION: latest
   PHP_VERSION: 8.3
   PHPUNIT_VERSION: 11
 
 jobs:
   sonarqube:
     name: SonarQube
-    runs-on: ${{ env.UBUNTU_VERSION }}
+    runs-on: ubuntu-latest
 
     steps:
       - name: Setup PHP ${{ env.PHP_VERSION }}

.github/workflows/tests.yml

@@ -32,10 +32,9 @@ jobs:
             phpunit-versions: 12
           - php-versions: "8.4"
             phpunit-versions: 12
-            env:
-              - PHP_CS_FIXER_IGNORE_ENV: 1
+
     runs-on: ${{ matrix.operating-system }}
-    name: OS ${{ operating-system }} | PHP ${{ matrix.php-versions }}
+    name: OS ${{ matrix.operating-system }} | PHP ${{ matrix.php-versions }}
 
     steps:
       - name: Setup PHP ${{ matrix.php-versions }}
@@ -91,10 +90,12 @@ jobs:
       - name: Server warm up
         run: sleep 5
 
-      # TODO: the problem is that Prettier does not work properly on Windows. Good to fix this in the future.
-      - if: matrix.operating-system == 'windows-latest'
-        name: Run short test suite
-        run: npm run test:small
-      - if: matrix.operating-system != 'windows-latest'
-        name: Run full test suite
+      - if: matrix.php-versions != '8.4'
+        name: Run test suite
+        shell: bash
         run: npm run test
+
+      - if: matrix.php-versions == '8.4'
+        name: Run test suite for PHP 8.4
+        shell: bash
+        run: npm run test:8.4

package.json

@@ -13,6 +13,7 @@
     "markdownlint": "markdownlint --config .markdownlint.json \"*.md\"",
     "package": "npx npm-package-json-lint .",
     "php": "npm run phpcs && npm run phpmd && npm run phpcs-fixer",
+    "php:8.4": "npm run phpcs && npm run phpmd",
     "phpcs": "php ./vendor/bin/phpcs --standard=PSR2 src/",
     "phpcs-fixer": "php ./vendor/bin/php-cs-fixer --verbose check",
     "phpcs-fixer:fix": "php ./vendor/bin/php-cs-fixer fix",
@@ -23,10 +24,9 @@
     "psalm": "php ./vendor/bin/psalm --show-info=true",
     "sort": "sort-package-json ./package.json ./composer.json",
     "start-server": "npx serve -n tests/data",
-    "style": "npm run style:windows && npm run prettier",
-    "style:windows": "npm run markdown && npm run markdownlint && npm run json && npm run package && npm run lint",
+    "style": "npm run markdown && npm run markdownlint && npm run json && npm run package && npm run lint && npm run prettier",
     "test": "npm run style && npm run php && npm run coverage",
-    "test:small": "npm run style:windows && npm run php && npm run coverage"
+    "test:8.4": "npm run style && npm run php:8.4 && npm run coverage"
   },
   "remarkConfig": {
     "plugins": [