Revert "Align CPU behavior with CUDA for ConvTranspose when out_channels=0 (pytorch#142859)"

This reverts commit cb814c0.

Reverted pytorch#142859 on behalf of https://github.com/malfet due to It broke ROCM tests again, see https://hud.pytorch.org/hud/pytorch/pytorch/5cd2b34e821c293909fe3f6a958767b9c535c094/1?per_page=50&name_filter=rocm&mergeLF=true ([comment](pytorch#142859 (comment)))

Author: pytorchmergebot

aten/src/ATen/native/NaiveConvolutionTranspose2d.cpp

@@ -78,8 +78,8 @@ static inline void slow_conv_transpose2d_shape_check(
 
   if (weight.defined()) {
     TORCH_CHECK(
-        (weight.dim() == 2 || weight.dim() == 4),
-        "2D or 4D weight tensor expected, but got: ",
+        weight.numel() != 0 && (weight.dim() == 2 || weight.dim() == 4),
+        "non-empty 2D or 4D weight tensor expected, but got: ",
         weight.sizes());
     if (bias.defined()) {
       check_dim_size(bias, 1, 0, weight.size(1));

aten/src/ATen/native/NaiveConvolutionTranspose3d.cpp

@@ -98,8 +98,8 @@ static inline void slow_conv_transpose3d_shape_check(
   if (weight.defined()) {
     /* TODO: TORCH_CHECK just have 2 args: condition and message */
     TORCH_CHECK(
-        weight.dim() == 5,
-        "5D (n_output_plane x n_input_plane x kernel_depth",
+        weight.numel() != 0 && weight.dim() == 5,
+        "non-empty 5D (n_output_plane x n_input_plane x kernel_depth",
         " x kernel_height x kernel_width) tensor ",
         "expected for weight, but got: ",
         weight.sizes());

test/nn/test_convolution.py

@@ -40,7 +40,6 @@
     skipCUDAIfRocmVersionLessThan,
     skipMeta,
     skipMPS,
-    skipXLA,
 )
 from torch.testing._internal.common_dtype import (
     floating_and_complex_types_and,
@@ -1750,29 +1749,6 @@ def test_conv2d_same_padding(self, device, dtype):
         actual = F.conv2d(x, y, padding="same", dilation=3)
         self.assertEqual(expect, actual, rtol=rtol, atol=atol)
 
-    @dtypes(torch.float)
-    # aten/src/ATen/native/mps/OperationUtils.mm: TORCH_INTERNAL_ASSERT([srcBuf length] > 0, "Placeholder tensor is empty!"); on MPS
-    @expectedFailureMPS
-    @skipXLA
-    def test_ConvTranspose_output_channels_0(self, device, dtype):
-        class Model(nn.Module):
-            def __init__(self, operator, dim):
-                super().__init__()
-                self.op = eval(
-                    f"torch.nn.{operator}{dim}d(in_channels=1, out_channels=0, kernel_size={tuple([1] * dim)})"
-                )
-
-            def forward(self, x):
-                x = self.op(x)
-                return x
-
-        for dim in [1, 2, 3]:
-            x = torch.randn([1] * (dim + 1), device=device, dtype=dtype)
-            model = Model("ConvTranspose", dim).to(device).to(dtype=dtype)
-            y = model(x)
-            self.assertEqual(y.numel(), 0)
-            self.assertEqual(x.shape[1:], y.shape[1:])
-
     @dtypes(torch.float, torch.cfloat)
     def test_conv3d_same_padding(self, device, dtype):
         if dtype is torch.cfloat: