Add JSHint checking.

Author: rwjblue

.jshintignore

@@ -0,0 +1 @@
+node_modules/*

.jshintrc

@@ -0,0 +1,39 @@
+{
+  "predef": [
+    "console",
+    "-Promise"
+  ],
+  "expr": true,
+  "proto": true,
+  "strict": true,
+  "indent": 2,
+  "camelcase": true,
+  "node": true,
+  "browser": false,
+  "boss": true,
+  "curly": true,
+  "latedef": "nofunc",
+  "debug": false,
+  "devel": false,
+  "eqeqeq": true,
+  "evil": true,
+  "forin": false,
+  "immed": false,
+  "laxbreak": false,
+  "newcap": true,
+  "noarg": true,
+  "noempty": false,
+  "quotmark": true,
+  "nonew": false,
+  "nomen": false,
+  "onevar": false,
+  "plusplus": false,
+  "regexp": false,
+  "undef": true,
+  "unused": true,
+  "sub": true,
+  "trailing": true,
+  "white": false,
+  "eqnull": true,
+  "esnext": true
+}

index.js

@@ -34,7 +34,7 @@ function findPackedTag(gitPath, sha) {
   if (fs.existsSync(packedRefsFilePath)) {
     var packedRefsFile = fs.readFileSync(packedRefsFilePath, {encoding: 'utf8'});
     var tagLine = packedRefsFile.split('\n').filter(function(line) {
-      return line.indexOf("refs/tags") > -1 && line.indexOf(sha) > -1;
+      return line.indexOf('refs/tags') > -1 && line.indexOf(sha) > -1;
     })[0];
 
     if (tagLine) {
@@ -68,13 +68,12 @@ module.exports = function(gitPath) {
     abbreviatedSha: null,
     branch: null,
     tag: null
-  }
+  };
 
   try {
     var headFilePath   = path.join(gitPath, 'HEAD');
 
     if (fs.existsSync(headFilePath)) {
-      var branchSHA;
       var headFile = fs.readFileSync(headFilePath, {encoding: 'utf8'});
       var branchName = headFile.split('/').slice(-1)[0].trim();
       var refPath = headFile.split(' ')[1];

package.json

@@ -20,6 +20,7 @@
   },
   "homepage": "https://github.com/rwjblue/git-repo-info",
   "devDependencies": {
-    "mocha": "^1.21.4"
+    "mocha": "^1.21.4",
+    "mocha-jshint": "^1.1.0"
   }
 }

tests/.jshintrc

@@ -0,0 +1,45 @@
+{
+  "predef": [
+    "console",
+    "it",
+    "describe",
+    "beforeEach",
+    "afterEach",
+    "before",
+    "after",
+    "-Promise"
+  ],
+  "expr": true,
+  "proto": true,
+  "strict": true,
+  "indent": 2,
+  "camelcase": true,
+  "node": true,
+  "browser": false,
+  "boss": true,
+  "curly": true,
+  "latedef": "nofunc",
+  "debug": false,
+  "devel": false,
+  "eqeqeq": true,
+  "evil": true,
+  "forin": false,
+  "immed": false,
+  "laxbreak": false,
+  "newcap": true,
+  "noarg": true,
+  "noempty": false,
+  "quotmark": true,
+  "nonew": false,
+  "nomen": false,
+  "onevar": false,
+  "plusplus": false,
+  "regexp": false,
+  "undef": true,
+  "unused": true,
+  "sub": true,
+  "trailing": true,
+  "white": false,
+  "eqnull": true,
+  "esnext": true
+}

tests/index.js

@@ -4,6 +4,8 @@ var assert = require('assert');
 var path = require('path');
 var repoInfo = require('../index');
 
+require('mocha-jshint')();
+
 var root = process.cwd();
 var testFixturesPath = path.join(__dirname, 'fixtures');
 var gitDir = 'dot-git';
@@ -15,7 +17,7 @@ describe('git-repo-info', function() {
 
   afterEach(function() {
     process.chdir(root);
-  })
+  });
 
   describe('repo lookup', function() {
     var repoRoot = path.join(testFixturesPath, 'nested-repo');
@@ -52,57 +54,57 @@ describe('git-repo-info', function() {
   describe('repoInfo', function() {
     it('returns an object with repo info', function() {
       var repoRoot = path.join(testFixturesPath, 'nested-repo');
-      var result = repoInfo(path.join(repoRoot, gitDir))
+      var result = repoInfo(path.join(repoRoot, gitDir));
 
       var expected = {
         branch: 'master',
         sha: '5359aabd3872d9ffd160712e9615c5592dfe6745',
         abbreviatedSha: '5359aabd38',
         tag: null
-      }
+      };
 
       assert.deepEqual(result, expected);
     });
 
     it('returns an object with repo info', function() {
       var repoRoot = path.join(testFixturesPath, 'detached-head');
-      var result = repoInfo(path.join(repoRoot, gitDir))
+      var result = repoInfo(path.join(repoRoot, gitDir));
 
       var expected = {
         branch: null,
         sha: '9dac893d5a83c02344d91e79dad8904889aeacb1',
         abbreviatedSha: '9dac893d5a',
         tag: null
-      }
+      };
 
       assert.deepEqual(result, expected);
     });
 
 
     it('returns an object with repo info, including the tag (packed tags)', function() {
       var repoRoot = path.join(testFixturesPath, 'tagged-commit-packed');
-      var result = repoInfo(path.join(repoRoot, gitDir))
+      var result = repoInfo(path.join(repoRoot, gitDir));
 
       var expected = {
         branch: 'master',
         sha: '5359aabd3872d9ffd160712e9615c5592dfe6745',
         abbreviatedSha: '5359aabd38',
         tag: 'my-tag'
-      }
+      };
 
       assert.deepEqual(result, expected);
     });
 
     it('returns an object with repo info, including the tag (unpacked tags)', function() {
       var repoRoot = path.join(testFixturesPath, 'tagged-commit-unpacked');
-      var result = repoInfo(path.join(repoRoot, gitDir))
+      var result = repoInfo(path.join(repoRoot, gitDir));
 
       var expected = {
         branch: 'master',
         sha: '5359aabd3872d9ffd160712e9615c5592dfe6745',
         abbreviatedSha: '5359aabd38',
         tag: 'my-tag'
-      }
+      };
 
       assert.deepEqual(result, expected);
     });