Add DataRemaining, use it to reduce CursorPacket size (#744)

Author: mibac138

Source/Common/Networking/Packet/CursorPacket.cs

@@ -35,9 +35,11 @@ public void Bind(PacketBuffer buf)
             buf.BindWith(ref x, FloatAsShortBinder);
             buf.BindWith(ref z, FloatAsShortBinder);
 
-            buf.BindWith(ref dragX, FloatAsShortBinder);
-            if (dragX != 0)
+            if (/* reading */ buf.DataRemaining || /* writing */ HasDrag)
+            {
+                buf.BindWith(ref dragX, FloatAsShortBinder);
                 buf.BindWith(ref dragZ, FloatAsShortBinder);
+            }
         }
     }
 

Source/Common/Networking/Packet/IPacket.cs

@@ -82,6 +82,8 @@ public abstract class PacketBuffer(bool isWriting)
     public virtual ByteReader Reader => throw new Exception();
     public virtual ByteWriter Writer => throw new Exception();
 
+    public abstract bool DataRemaining { get; }
+
     public abstract void Bind(ref byte obj);
 
     public abstract void Bind(ref sbyte obj);
@@ -132,6 +134,7 @@ public abstract void Bind<K, V>(ref Dictionary<K, V> obj, Binder<K> bindKey, Bin
 public sealed class PacketReader(ByteReader reader) : PacketBuffer(false)
 {
     public override ByteReader Reader => reader;
+    public override bool DataRemaining => reader.Left > 0;
 
     public override void Bind(ref byte obj) => obj = reader.ReadByte();
 
@@ -223,6 +226,7 @@ public override void Bind<K, V>(ref Dictionary<K, V> obj, Binder<K> bindKey, Bin
 public sealed class PacketWriter(ByteWriter writer) : PacketBuffer(true)
 {
     public override ByteWriter Writer => writer;
+    public override bool DataRemaining => false;
 
     public override void Bind(ref byte obj) => writer.WriteByte(obj);
 

Source/Tests/packet-serializations/ClientCursorPacket.verified.txt

@@ -1,3 +1,3 @@
 01-FF
-02-00-2A-7B-00-B3-FF-00-00
+02-00-2A-7B-00-B3-FF
 03-02-03-0F-00-19-00-2C-00-37-00