Explain program state change #508

Author: Tick-git

Source/Client/Factions/Page_ConfigureStartingPawns_Multifaction.cs

@@ -54,11 +54,8 @@ private void GenerateTemporaryFaction()
         private void GeneratePawnsForConfigurePage()
         {
             var prevProgramState = Current.programStateInt;
+            SetEntryProgramStateForCorrectPawnCreation();
 
-            // Old Comment: Set ProgramState.Entry so that InInterface is false
-            // TODO: Why is this necessary?
-            // TODO: feel like there is a better way to do this
-            Current.programStateInt = ProgramState.Entry;
             Current.Game.InitData.playerFaction = _temporaryFactionForPawnCreation;
 
             try
@@ -71,6 +68,16 @@ private void GeneratePawnsForConfigurePage()
             }
         }
 
+        private static void SetEntryProgramStateForCorrectPawnCreation()
+        {
+            // Set ProgramState.Entry to ensure InInterface is false.
+            // (#508 Tick-git)  InInterface seems unrelated to PawnCreation to me,
+            //                  but it's necessary because it makes Faction.OfPlayer return
+            //                  the temporary generated faction — which is required for proper apparel generation.
+
+            Current.programStateInt = ProgramState.Entry;
+        }
+
         private void GeneratingPawns()
         {
             _scenario.PostIdeoChosen();