Extra logs when connecting using Steam

Hopefully should help diagnose some networking issues

Author: mibac138

Source/Client/Networking/NetworkingSteam.cs

@@ -134,6 +134,7 @@ public void Tick()
                     var preConnect = playerManager.OnPreConnect(packet.remote);
                     if (preConnect != null)
                     {
+                        ServerLog.Log($"Rejected incoming connection from {packet.remote}: {preConnect}");
                         conn.Close(preConnect.Value);
                         continue;
                     }
@@ -149,11 +150,15 @@ public void Tick()
 
                     conn.Send(Packets.Server_SteamAccept);
                 }
-
-                if (!packet.joinPacket && player != null)
+                else if (!packet.joinPacket && player != null)
                 {
                     player.HandleReceive(packet.data, packet.reliable);
                 }
+                else
+                {
+                    ServerLog.Error(
+                        $"Received a join packet: {packet.joinPacket} for player: {player} (player should only be null when joinPacket is true)");
+                }
             }
         }
 
@@ -175,13 +180,14 @@ public static void InitCallbacks()
         {
             p2pFail = Callback<P2PSessionConnectFail_t>.Create(fail =>
             {
-                var session = Multiplayer.session;
-                if (session == null) return;
-
                 var remoteId = fail.m_steamIDRemote;
                 var error = (EP2PSessionError)fail.m_eP2PSessionError;
+                ServerLog.Error($"Steam P2P session fail for {remoteId}: {error}");
+
+                var session = Multiplayer.session;
+                if (session == null) return;
 
-                if (Multiplayer.Client is SteamBaseConn clientConn && clientConn.remoteId == remoteId)
+                if (session.client is SteamBaseConn clientConn && clientConn.remoteId == remoteId)
                     clientConn.OnError(error);
 
                 var server = Multiplayer.LocalServer;

Source/Client/Networking/SteamIntegration.cs

@@ -4,6 +4,7 @@
 using Multiplayer.Client.Networking;
 using Multiplayer.Client.Util;
 using Multiplayer.Client.Windows;
+using Multiplayer.Common;
 using RimWorld;
 using Steamworks;
 using UnityEngine;
@@ -29,6 +30,7 @@ public static void InitCallbacks()
 
             sessionReq = Callback<P2PSessionRequest_t>.Create(req =>
             {
+                ServerLog.Log($"Received P2P session request from {req.m_steamIDRemote}");
                 var session = Multiplayer.session;
                 if (Multiplayer.LocalServer?.settings.steam == true && !session.pendingSteam.Contains(req.m_steamIDRemote))
                 {

Source/Common/Util/ServerLog.cs

@@ -2,7 +2,7 @@
 
 namespace Multiplayer.Common
 {
-    public class ServerLog
+    public static class ServerLog
     {
         public static Action<string>? info;
         public static Action<string>? error;