Disable Trade/Transport/Caravan Session Buttons for Other Factions (#507)

SaberShip · SaberShip · web-flow · commit f1a12cba1a2c · 2025-07-01T10:50:45.000-05:00
* Disable trade/caravan session buttons for other factions

* Display correct faction name in trade UI

* Disable "M&lt;" button.

---------

Co-authored-by: SaberShip &lt;sabership.noreply@github.com&gt;
diff --git a/Source/Client/Comp/Map/MultiplayerMapComp.cs b/Source/Client/Comp/Map/MultiplayerMapComp.cs
@@ -35,12 +35,12 @@ public MultiplayerMapComp(Map map)
             sessionManager = new(map);
         }
 
-        public CaravanFormingSession CreateCaravanFormingSession(bool reform, Action onClosed, bool mapAboutToBeRemoved, IntVec3? meetingSpot = null)
+        public CaravanFormingSession CreateCaravanFormingSession(Faction faction, bool reform, Action onClosed, bool mapAboutToBeRemoved, IntVec3? meetingSpot = null)
         {
             var caravanForming = sessionManager.GetFirstOfType<CaravanFormingSession>();
             if (caravanForming == null)
             {
-                caravanForming = new CaravanFormingSession(map, reform, onClosed, mapAboutToBeRemoved, meetingSpot);
+                caravanForming = new CaravanFormingSession(faction, map, reform, onClosed, mapAboutToBeRemoved, meetingSpot);
                 if (!sessionManager.AddSession(caravanForming))
                 {
                     // Shouldn't happen if the session doesn't exist already, show an error just in case
@@ -51,12 +51,12 @@ public CaravanFormingSession CreateCaravanFormingSession(bool reform, Action onC
             return caravanForming;
         }
 
-        public TransporterLoading CreateTransporterLoadingSession(List<CompTransporter> transporters)
+        public TransporterLoading CreateTransporterLoadingSession(Faction faction, List<CompTransporter> transporters)
         {
             var transporterLoading = sessionManager.GetFirstOfType<TransporterLoading>();
             if (transporterLoading == null)
             {
-                transporterLoading = new TransporterLoading(map, transporters);
+                transporterLoading = new TransporterLoading(faction, map, transporters);
                 if (!sessionManager.AddSession(transporterLoading))
                 {
                     // Shouldn't happen if the session doesn't exist already, show an error just in case
diff --git a/Source/Client/Persistent/CaravanFormingPatches.cs b/Source/Client/Persistent/CaravanFormingPatches.cs
@@ -7,6 +7,7 @@
 using UnityEngine;
 using Verse;
 using static Verse.Widgets;
+using System.Reflection;
 
 namespace Multiplayer.Client.Persistent
 {
@@ -168,25 +169,27 @@ static void Prefix(Dialog_FormCaravan __instance, Map map, bool reform, Action o
             if (__instance.GetType() != typeof(Dialog_FormCaravan))
                 return;
 
+            Faction faction = Faction.OfPlayer;
+
             // Handles showing the dialog from TimedForcedExit.CompTick -> TimedForcedExit.ForceReform
             // (note TimedForcedExit is obsolete)
             if (Multiplayer.ExecutingCmds || Multiplayer.Ticking)
             {
                 var comp = map.MpComp();
                 if (comp.sessionManager.GetFirstOfType<CaravanFormingSession>() == null)
-                    comp.CreateCaravanFormingSession(reform, onClosed, mapAboutToBeRemoved, designatedMeetingPoint);
+                    comp.CreateCaravanFormingSession(faction, reform, onClosed, mapAboutToBeRemoved, designatedMeetingPoint);
             }
             else // Handles opening from the interface: forming gizmos, reforming gizmos and caravan hitching spots
             {
-                StartFormingCaravan(map, reform, designatedMeetingPoint);
+                StartFormingCaravan(faction, map, reform, designatedMeetingPoint);
             }
         }
 
         [SyncMethod]
-        internal static void StartFormingCaravan(Map map, bool reform = false, IntVec3? designatedMeetingPoint = null, int? routePlannerWaypoint = null)
+        internal static void StartFormingCaravan(Faction faction, Map map, bool reform = false, IntVec3? designatedMeetingPoint = null, int? routePlannerWaypoint = null)
         {
             var comp = map.MpComp();
-            var session = comp.CreateCaravanFormingSession(reform, null, false, designatedMeetingPoint);
+            var session = comp.CreateCaravanFormingSession(faction, reform, null, false, designatedMeetingPoint);
 
             if (TickPatch.currentExecutingCmdIssuedBySelf)
             {
@@ -224,7 +227,7 @@ static bool Prefix(Map origin, int tile)
                 return true;
 
             // Override behavior in multiplayer
-            DialogFormCaravanCtorPatch.StartFormingCaravan(origin, routePlannerWaypoint: tile);
+            DialogFormCaravanCtorPatch.StartFormingCaravan(Faction.OfPlayer, origin, routePlannerWaypoint: tile);
 
             return false;
         }
@@ -241,4 +244,101 @@ static bool Prefix(TimedForcedExit __instance)
             return true;
         }
     }
+
+    [HarmonyPatch()]
+    static class DisableCaravanFormCheckboxForOtherFactions
+    {
+        static MethodInfo TargetMethod() {
+            return typeof(Widgets).GetMethod("Checkbox", [
+                typeof(Vector2), typeof(bool).MakeByRefType(), typeof(float), typeof(bool), typeof(bool), typeof(Texture2D), typeof(Texture2D)
+            ]);
+        }
+
+        static bool Prefix(Vector2 topLeft, bool checkOn, bool disabled)
+        {
+            if (CaravanFormingProxy.drawing == null || CaravanFormingProxy.drawing.Session?.faction == Multiplayer.RealPlayerFaction)
+                return true;
+
+            if (disabled)
+                return true;
+
+            Widgets.Checkbox(topLeft, ref checkOn, disabled: true);
+            return false;
+        }
+    }
+
+    [HarmonyPatch()]
+    static class DisableCaravanFormSuppliesCheckboxForOtherFactions
+    {
+        static MethodInfo TargetMethod() {
+            return typeof(Widgets).GetMethod("CheckboxLabeled", [
+                typeof(Rect), typeof(string), typeof(bool).MakeByRefType(), typeof(bool), typeof(Texture2D), typeof(Texture2D), typeof(bool), typeof(bool)
+            ]);
+        }
+
+        static bool Prefix(Rect rect, string label, bool checkOn, bool disabled)
+        {
+            if (CaravanFormingProxy.drawing == null || CaravanFormingProxy.drawing.Session?.faction == Multiplayer.RealPlayerFaction)
+                return true;
+
+            if (disabled || label != "AutomaticallySelectTravelSupplies".Translate())
+                return true;
+
+            Widgets.CheckboxLabeled(rect, label, ref checkOn, disabled: true, null, null, placeCheckboxNearText: true);
+            return false;
+        }
+    }
+
+    [HarmonyPatch(typeof(Widgets), nameof(Widgets.ButtonText), typeof(Rect), typeof(string), typeof(bool), typeof(bool), typeof(bool), typeof(TextAnchor))]
+    static class DisableCaravanFormControlButtonsForOtherFactions
+    {
+        static bool Prefix(Rect rect, string label, ref bool __result)
+        {
+            if (CaravanFormingProxy.drawing == null || CaravanFormingProxy.drawing.Session?.faction == Multiplayer.RealPlayerFaction)
+                return true;
+
+            if (label != "ResetButton".Translate() && label != "CancelButton".Translate() && label != "ChangeRouteButton".Translate() && label != "Send".Translate())
+                return true;
+
+            __result = false;
+            return false;
+        }
+    }
+
+    [HarmonyPatch(typeof(Widgets), nameof(Widgets.ButtonText))]
+    [HarmonyPatch(new[] { typeof(Rect), typeof(string), typeof(bool), typeof(bool), typeof(bool), typeof(TextAnchor) })]
+    static class DisableCaravanFormCountButtonsForOtherFactions
+    {
+        static bool Prefix(Rect rect, string label, ref bool __result)
+        {
+            if (CaravanFormingProxy.drawing == null || CaravanFormingProxy.drawing.Session?.faction == Multiplayer.RealPlayerFaction)
+                return true;
+
+            if (label != "0" && label != "M<" && label != "<<" && label != "<" && label != ">" && label != ">>" && label != ">M")
+                return true;
+
+            GUI.color = Widgets.InactiveColor;
+            Widgets.TextArea(rect, label, true);
+            GUI.color = Color.white;
+            __result = false;
+            return false;
+        }
+    }
+
+    [HarmonyPatch()]
+    static class DisableCaravanFormCountTextBoxForOtherFactions
+    {
+        static MethodInfo TargetMethod() {
+            return typeof(Widgets).GetMethod("TextFieldNumeric", BindingFlags.Public | BindingFlags.Static).MakeGenericMethod(typeof(int));
+        }
+        static bool Prefix(Rect rect, int val)
+        {
+            if (CaravanFormingProxy.drawing == null || CaravanFormingProxy.drawing.Session?.faction == Multiplayer.RealPlayerFaction)
+                return true;
+
+            GUI.color = Color.white;
+            Widgets.TextArea(rect, val.ToString(), true);
+            return false;
+        }
+    }
 }
diff --git a/Source/Client/Persistent/CaravanFormingSession.cs b/Source/Client/Persistent/CaravanFormingSession.cs
@@ -11,6 +11,8 @@ public class CaravanFormingSession : ExposableSession, ISessionWithTransferables
     {
         public Map map;
 
+        public Faction faction;
+
         public bool reform;
         public Action onClosed;
         public bool mapAboutToBeRemoved;
@@ -24,12 +26,13 @@ public class CaravanFormingSession : ExposableSession, ISessionWithTransferables
 
         public override Map Map => map;
 
-        public CaravanFormingSession(Map map) : base(map)
+        public CaravanFormingSession(Faction faction, Map map) : base(map)
         {
             this.map = map;
+            this.faction = faction;
         }
 
-        public CaravanFormingSession(Map map, bool reform, Action onClosed, bool mapAboutToBeRemoved, IntVec3? meetingSpot = null) : this(map)
+        public CaravanFormingSession(Faction faction, Map map, bool reform, Action onClosed, bool mapAboutToBeRemoved, IntVec3? meetingSpot = null) : this(faction, map)
         {
             this.reform = reform;
             this.onClosed = onClosed;
diff --git a/Source/Client/Persistent/Trading.cs b/Source/Client/Persistent/Trading.cs
@@ -22,6 +22,8 @@ public class MpTradeSession : ExposableSession, ISessionWithTransferables, ISess
         public MpTradeDeal deal;
         public bool giftsOnly;
 
+        public Faction NegotiatorFaction => playerNegotiator?.Faction;
+
         public string Label
         {
             get
diff --git a/Source/Client/Persistent/TradingUI.cs b/Source/Client/Persistent/TradingUI.cs
@@ -48,15 +48,15 @@ public override void DoWindowContents(Rect inRect)
             if (selectedTab == -1 && trading.Count > 0)
                 selectedTab = 0;
 
-            if (selectedTab == -1)
+            if (selectedTab == -1 || tabs.Count == 0)
             {
                 Close();
                 return;
             }
 
             int rows = Mathf.CeilToInt(tabs.Count / 3f);
             inRect.yMin += rows * TabDrawer.TabHeight + 3;
-            TabDrawer.DrawTabs(inRect, tabs, rows);
+            TabDrawer.DrawTabs(inRect, tabs);
 
             inRect.yMin += 10f;
 
@@ -67,8 +67,10 @@ public override void DoWindowContents(Rect inRect)
                 selectedSession = session.SessionId;
             }
 
+            Faction factionContext = session.NegotiatorFaction;
             try
             {
+                factionContext = FactionContext.Push(factionContext);
                 MpTradeSession.SetTradeSession(session);
                 drawingTrade = this;
 
@@ -124,6 +126,9 @@ public override void DoWindowContents(Rect inRect)
             {
                 drawingTrade = null;
                 MpTradeSession.SetTradeSession(null);
+                if (factionContext != null) {
+                    FactionContext.Pop();
+                }
             }
         }
 
@@ -246,6 +251,77 @@ public static List<Tradeable> AllTradeables()
         }
     }
 
+    [HarmonyPatch(typeof(Widgets), nameof(Widgets.ButtonText), typeof(Rect), typeof(string), typeof(bool), typeof(bool), typeof(bool), typeof(TextAnchor))]
+    static class DisableTradeControlButtonsForOtherFactions
+    {
+        static bool Prefix(Rect rect, string label, ref bool __result)
+        {
+            if (TradingWindow.drawingTrade == null || MpTradeSession.current.NegotiatorFaction == Multiplayer.RealPlayerFaction)
+                return true;
+
+            if (label != "ResetButton".Translate() && label != "CancelButton".Translate() && label != "OfferGifts".Translate() && label != "AcceptButton".Translate())
+                return true;
+
+            __result = false;
+            return false;
+        }
+    }
+
+    [HarmonyPatch(typeof(Widgets), nameof(Widgets.ButtonImageWithBG))]
+    static class DisableTradeModeButtonForOtherFactions
+    {
+        private static readonly Texture2D GiftModeIcon = ContentFinder<Texture2D>.Get("UI/Buttons/GiftMode");
+	    private static readonly Texture2D TradeModeIcon = ContentFinder<Texture2D>.Get("UI/Buttons/TradeMode");
+
+        static bool Prefix(Rect butRect, Texture2D image, ref bool __result)
+        {
+            if (TradingWindow.drawingTrade == null || MpTradeSession.current.NegotiatorFaction == Multiplayer.RealPlayerFaction)
+                return true;
+
+            if (image != GiftModeIcon && image != TradeModeIcon)
+                return true;
+
+            __result = false;
+            return false;
+        }
+    }
+
+    [HarmonyPatch(typeof(Widgets), nameof(Widgets.ButtonText), typeof(Rect), typeof(string), typeof(bool), typeof(bool), typeof(bool), typeof(TextAnchor))]
+    static class DisableTradeCountButtonsForOtherFactions
+    {
+        static bool Prefix(Rect rect, string label, ref bool __result)
+        {
+            if (TradingWindow.drawingTrade == null || MpTradeSession.current.NegotiatorFaction == Multiplayer.RealPlayerFaction)
+                return true;
+
+            if (label != "0" && label != "M<" && label != "<<" && label != "<" && label != ">" && label != ">>" && label != ">M")
+                return true;
+
+            GUI.color = Widgets.InactiveColor;
+            Widgets.TextArea(rect, label, true);
+            GUI.color = Color.white;
+            __result = false;
+            return false;
+        }
+    }
+
+    [HarmonyPatch()]
+    static class DisableTradeCountTextBoxForOtherFactions
+    {
+        static MethodInfo TargetMethod() {
+            return typeof(Widgets).GetMethod("TextFieldNumeric", BindingFlags.Public | BindingFlags.Static).MakeGenericMethod(typeof(int));
+        }
+        static bool Prefix(Rect rect, int val)
+        {
+            if (TradingWindow.drawingTrade == null || MpTradeSession.current.NegotiatorFaction == Multiplayer.RealPlayerFaction)
+                return true;
+
+            GUI.color = Color.white;
+            Widgets.TextArea(rect, val.ToString(), true);
+            return false;
+        }
+    }
+
     [HarmonyPatch(typeof(Widgets), nameof(Widgets.ButtonTextWorker))]
     static class MakeCancelTradeButtonRed
     {
diff --git a/Source/Client/Persistent/TransporterLoadingPatches.cs b/Source/Client/Persistent/TransporterLoadingPatches.cs
diff --git a/Source/Client/Persistent/TransporterLoadingSession.cs b/Source/Client/Persistent/TransporterLoadingSession.cs

Original file line number	Diff line number	Diff line change
`@@ -35,12 +35,12 @@ public MultiplayerMapComp(Map map)`
`35`	`35`	`sessionManager = new(map);`
`36`	`36`	`}`
`37`	`37`
`38`		`- public CaravanFormingSession CreateCaravanFormingSession(bool reform, Action onClosed, bool mapAboutToBeRemoved, IntVec3? meetingSpot = null)`
	`38`	`+ public CaravanFormingSession CreateCaravanFormingSession(Faction faction, bool reform, Action onClosed, bool mapAboutToBeRemoved, IntVec3? meetingSpot = null)`
`39`	`39`	`{`
`40`	`40`	`var caravanForming = sessionManager.GetFirstOfType<CaravanFormingSession>();`
`41`	`41`	`if (caravanForming == null)`
`42`	`42`	`{`
`43`		`- caravanForming = new CaravanFormingSession(map, reform, onClosed, mapAboutToBeRemoved, meetingSpot);`
	`43`	`+ caravanForming = new CaravanFormingSession(faction, map, reform, onClosed, mapAboutToBeRemoved, meetingSpot);`
`44`	`44`	`if (!sessionManager.AddSession(caravanForming))`
`45`	`45`	`{`
`46`	`46`	`// Shouldn't happen if the session doesn't exist already, show an error just in case`
`@@ -51,12 +51,12 @@ public CaravanFormingSession CreateCaravanFormingSession(bool reform, Action onC`
`51`	`51`	`return caravanForming;`
`52`	`52`	`}`
`53`	`53`
`54`		`- public TransporterLoading CreateTransporterLoadingSession(List<CompTransporter> transporters)`
	`54`	`+ public TransporterLoading CreateTransporterLoadingSession(Faction faction, List<CompTransporter> transporters)`
`55`	`55`	`{`
`56`	`56`	`var transporterLoading = sessionManager.GetFirstOfType<TransporterLoading>();`
`57`	`57`	`if (transporterLoading == null)`
`58`	`58`	`{`
`59`		`- transporterLoading = new TransporterLoading(map, transporters);`
	`59`	`+ transporterLoading = new TransporterLoading(faction, map, transporters);`
`60`	`60`	`if (!sessionManager.AddSession(transporterLoading))`
`61`	`61`	`{`
`62`	`62`	`// Shouldn't happen if the session doesn't exist already, show an error just in case`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@ public class CaravanFormingSession : ExposableSession, ISessionWithTransferables`
`11`	`11`	`{`
`12`	`12`	`public Map map;`
`13`	`13`
	`14`	`+ public Faction faction;`
	`15`	`+`
`14`	`16`	`public bool reform;`
`15`	`17`	`public Action onClosed;`
`16`	`18`	`public bool mapAboutToBeRemoved;`
`@@ -24,12 +26,13 @@ public class CaravanFormingSession : ExposableSession, ISessionWithTransferables`
`24`	`26`
`25`	`27`	`public override Map Map => map;`
`26`	`28`
`27`		`- public CaravanFormingSession(Map map) : base(map)`
	`29`	`+ public CaravanFormingSession(Faction faction, Map map) : base(map)`
`28`	`30`	`{`
`29`	`31`	`this.map = map;`
	`32`	`+ this.faction = faction;`
`30`	`33`	`}`
`31`	`34`
`32`		`- public CaravanFormingSession(Map map, bool reform, Action onClosed, bool mapAboutToBeRemoved, IntVec3? meetingSpot = null) : this(map)`
	`35`	`+ public CaravanFormingSession(Faction faction, Map map, bool reform, Action onClosed, bool mapAboutToBeRemoved, IntVec3? meetingSpot = null) : this(faction, map)`
`33`	`36`	`{`
`34`	`37`	`this.reform = reform;`
`35`	`38`	`this.onClosed = onClosed;`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@ public class MpTradeSession : ExposableSession, ISessionWithTransferables, ISess`
`22`	`22`	`public MpTradeDeal deal;`
`23`	`23`	`public bool giftsOnly;`
`24`	`24`
	`25`	`+ public Faction NegotiatorFaction => playerNegotiator?.Faction;`
	`26`	`+`
`25`	`27`	`public string Label`
`26`	`28`	`{`
`27`	`29`	`get`