Skip to content

Conversation

@Atticus1806
Copy link
Contributor

No description provided.

@Atticus1806 Atticus1806 marked this pull request as ready for review August 29, 2023 14:39
@JackTemaki
Copy link
Contributor

@christophmluscher is it possible to get the modifications to the Systems in smaller PRs? This is sheer impossible to review.

@JackTemaki
Copy link
Contributor

After an offline discussion with @Atticus1806 , given that the setup changes are breaking existing setups and possibly need multiple weeks/months of review for a rather deprecated pipeline, I will do a local copy of setup within the tedlium 2 baseline folder. Then we can merge the setup now, and step-by-step update the setup code with smaller PRs.

@christophmluscher
Copy link
Contributor

wait for #182 #179

@Atticus1806 Atticus1806 requested a review from Marvin84 January 22, 2024 14:51
Copy link
Contributor

@Marvin84 Marvin84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

from .nn_config.nn_args import get_nn_args


def run_gmm_system():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the FSA bug correction included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. Where / how would that be included? RASR version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it should be

@christophmluscher
Copy link
Contributor

PR #179 and #182 are merged here and into main. so this can proceed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants