Skip to content

Conversation

@SimBe195
Copy link
Collaborator

@SimBe195 SimBe195 commented May 9, 2025

Add a trampoline class PythonLabelScorer and lots of pybindings that allow implementation of LabelScorers in python. librasr now exposes an abstract base class LabelScorer which can be inherited in python. A subclass can then be registered in the RASR label scorer factory via register_label_scorer_type and thus be instantiated by RASR for search.

Since the constructor of a LabelScorer is supposed to take a RASR Core::Configuration object this PR adds a simple __getitem__ function to the Configuration pybinds in order to allow python-implemented label scorers to make use of config parameters.

For the future it would be good to extend/overhaul the Configuration pybinds to improve how the config can be interacted with from python-side. But this is a separate future issue.

Depends on #117.

Simon Berger and others added 30 commits February 19, 2025 19:10
@SimBe195 SimBe195 requested review from curufinwe and larissakl May 9, 2025 09:38
Base automatically changed from search_python_bindings to master July 23, 2025 15:12
Copy link
Contributor

@larissakl larissakl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I haven't tested it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants