-
Notifications
You must be signed in to change notification settings - Fork 16
Add functionality for LabelScorers implemented in python #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimBe195
wants to merge
62
commits into
master
Choose a base branch
from
python_label_scorer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lattice from beam
larissakl
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I haven't tested it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a trampoline class
PythonLabelScorerand lots of pybindings that allow implementation of LabelScorers in python.librasrnow exposes an abstract base classLabelScorerwhich can be inherited in python. A subclass can then be registered in the RASR label scorer factory viaregister_label_scorer_typeand thus be instantiated by RASR for search.Since the constructor of a
LabelScoreris supposed to take a RASRCore::Configurationobject this PR adds a simple__getitem__function to the Configuration pybinds in order to allow python-implemented label scorers to make use of config parameters.For the future it would be good to extend/overhaul the
Configurationpybinds to improve how the config can be interacted with from python-side. But this is a separate future issue.Depends on #117.