Update Nn::TransitionLabelScorer: remove wrapped LabelScorer #155
+22
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimBe195
reviewed
Nov 5, 2025
hannah220
reviewed
Nov 5, 2025
| result->score += transitionScores_[request.transitionType]; | ||
| } | ||
| LabelScorer::ScoreWithTime result; | ||
| result.score = transitionScores_[request.transitionType]; |
There was a problem hiding this comment.
Why is the timeframe initialized with 0?
Should it be for example currentStep of StepScoringContext class?
There was a problem hiding this comment.
We don't really use a scoring context in this label scorer and therefore have no information about the current timestep. LabelScorer::ScoreWithTime however needs a timeframe. Therefore I just set it to 0 because it is not used anyways. When using the TransitionLabelScorer in combination with another label scorer in the CombineLabelScorer, the maximum of both timesteps will be used for the result, so 0 won't break anything.
# Conflicts: # src/Nn/LabelScorer/CombineLabelScorer.hh # src/Nn/LabelScorer/EncoderDecoderLabelScorer.hh # src/Nn/LabelScorer/FixedContextOnnxLabelScorer.hh # src/Nn/LabelScorer/LabelScorer.cc # src/Nn/LabelScorer/LabelScorer.hh # src/Nn/LabelScorer/NoContextOnnxLabelScorer.hh # src/Nn/LabelScorer/NoOpLabelScorer.hh # src/Nn/LabelScorer/StatefulOnnxLabelScorer.hh # src/Nn/LabelScorer/TransitionLabelScorer.cc # src/Nn/LabelScorer/TransitionLabelScorer.hh
SimBe195
approved these changes
Nov 5, 2025
hannah220
approved these changes
Nov 5, 2025
curufinwe
approved these changes
Nov 6, 2025
curufinwe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TransitionLabelScorer was used with a base label scorer. However, we find it more intuitive to have it standalone such that it can be used together with another label scorer in the CombineLabelScorer.
Most function are just no op now and a dummy scoring context was needed.
Depends on #148.