Add word/silence-exit-penalty to Search::TreeTimesyncBeamSearch #158
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larissakl
commented
Oct 30, 2025
|
I also added a separate exit penalty for silence |
curufinwe
changed the title
curufinwe
approved these changes
Nov 4, 2025
hannah220
reviewed
Nov 5, 2025
| Lm::Score lmScore = languageModel_->score(wordEndExtension.lmHistory, st); | ||
| wordEndExtension.score += lmScore; | ||
| wordEndExtension.lmScore = lmScore; | ||
|
|
There was a problem hiding this comment.
You could move this part out of if (sts.size() != 0) sentence,
then if (lemma == lexicon_->specialLemma("silence")) will be done only once:
if (sts.size() != 0) {
require(sts.size() == 1);
const Bliss::SyntacticToken* st = sts.front();
// Add the LM score
Lm::Score lmScore = languageModel_->score(wordEndExtension.lmHistory, st);
wordEndExtension.score += lmScore;
wordEndExtension.lmScore = lmScore;
}
// Add exit penalty for silence or for non-silence word
if (lemma == lexicon_->specialLemma("silence")) {
wordEndExtension.score += silencePenalty_;
}
else {
wordEndExtension.score += wordExitPenalty_;
}
|
I would prefer to see this implemented as a new transition type instead of a config parameter so that the score is retrieved from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config-parameter to the TreeTimesyncBeamSearch for defining a word-exit-penalty which is added to the overall hypothesis score at each word end along with the LM-score.