From 83184a478bd8202813dde16a7b4489804e97a12e Mon Sep 17 00:00:00 2001 From: Albert Zeyer Date: Tue, 31 Aug 2021 01:04:30 +0200 Subject: [PATCH 1/2] DimensionTag TODO declare_same_as self_same_as dyn_size_ext assign safe --- returnn/tf/util/data.py | 1 + 1 file changed, 1 insertion(+) diff --git a/returnn/tf/util/data.py b/returnn/tf/util/data.py index f256fafda..deba18cee 100644 --- a/returnn/tf/util/data.py +++ b/returnn/tf/util/data.py @@ -443,6 +443,7 @@ def declare_same_as(self, other): return self_same_as.same_as = other_same_base self_same_as._same_as_tb = traceback.extract_stack() + # TODO this is unsafe, slightly incorrect... if self_same_as.dyn_size_ext is None: self_same_as.dyn_size_ext = other_same_base.dyn_size_ext elif other_same_base.dyn_size_ext is None: From 2d9fb64c6875a952e70a77d3932527d7236020c4 Mon Sep 17 00:00:00 2001 From: Albert Zeyer Date: Tue, 31 Aug 2021 01:05:06 +0200 Subject: [PATCH 2/2] DimensionTag TODO declare_same_as outdated size_placeholder assign --- returnn/tf/util/data.py | 1 + 1 file changed, 1 insertion(+) diff --git a/returnn/tf/util/data.py b/returnn/tf/util/data.py index deba18cee..84126a0a5 100644 --- a/returnn/tf/util/data.py +++ b/returnn/tf/util/data.py @@ -464,6 +464,7 @@ def declare_same_as(self, other): # maybe we can overtake the size_placeholder now. if self.same_as.dyn_size is not None and self.src_data: assert isinstance(self.src_axis, int) + # TODO Is this still needed? also looks wrong # Maybe it changed in the meanwhile, so check. if self.src_data.get_dim_tag(self.src_axis).description == self.description: self.src_data.size_placeholder[