Check earlier if we already have git params (#255)

Author: jmsanders

internal/cli/service_resolvecliparams.go

@@ -43,6 +43,11 @@ func resolveCliParams(yamlContent string) (string, []string, error) {
 		return "", nil, errors.Wrap(err, "failed to parse YAML")
 	}
 
+	// Skip if CLI init already has git event references
+	if cliInit := doc.TryReadStringAtPath("$.on.cli.init"); strings.Contains(cliInit, "event.git.") {
+		return yamlContent, nil, nil
+	}
+
 	gitParamsMap, err := extractGitParams(doc)
 	gitParamNames := getGitParamNames(gitParamsMap)
 	if err != nil {
@@ -52,11 +57,6 @@ func resolveCliParams(yamlContent string) (string, []string, error) {
 		return yamlContent, gitParamNames, nil
 	}
 
-	// Skip if CLI init already has git event references
-	if cliInit := doc.TryReadStringAtPath("$.on.cli.init"); strings.Contains(cliInit, "event.git.") {
-		return yamlContent, gitParamNames, nil
-	}
-
 	// Create new 'on' section if it doesn't exist
 	if !doc.hasPath("$.on") {
 		return prependOnSection(yamlContent, gitParamsMap), gitParamNames, nil