Add spinner to logs command (#266)

Author: robinaugh

internal/cli/service.go

@@ -575,7 +575,14 @@ func (s Service) DownloadLogs(cfg DownloadLogsConfig) error {
 		return errors.Wrap(err, "unable to fetch log archive request")
 	}
 
+	stopSpinner := spin(
+		"Downloading logs...",
+		s.StderrIsTTY,
+		s.Stderr,
+	)
+
 	logBytes, err := s.APIClient.DownloadLogs(LogDownloadRequest)
+	stopSpinner()
 	if err != nil {
 		return errors.Wrap(err, "unable to download logs")
 	}

internal/cli/service_logs_test.go

@@ -72,6 +72,7 @@ func TestService_DownloadLogs(t *testing.T) {
 		require.Error(t, err)
 		require.Contains(t, err.Error(), "unable to download logs")
 		require.Contains(t, err.Error(), "download failed")
+		require.Contains(t, s.mockStderr.String(), "Downloading logs...")
 	})
 
 	t.Run("when writing file fails", func(t *testing.T) {
@@ -97,6 +98,7 @@ func TestService_DownloadLogs(t *testing.T) {
 
 		require.Error(t, err)
 		require.Contains(t, err.Error(), "unable to write log file")
+		require.Contains(t, s.mockStderr.String(), "Downloading logs...")
 	})
 
 	t.Run("when download succeeds with single log file (no Contents)", func(t *testing.T) {
@@ -138,6 +140,7 @@ func TestService_DownloadLogs(t *testing.T) {
 		output := s.mockStdout.String()
 		require.Contains(t, output, "Logs downloaded to")
 		require.Contains(t, output, "task-123-logs.log")
+		require.Contains(t, s.mockStderr.String(), "Downloading logs...")
 	})
 
 	t.Run("when download succeeds with zip file (with Contents)", func(t *testing.T) {
@@ -181,6 +184,7 @@ func TestService_DownloadLogs(t *testing.T) {
 		output := s.mockStdout.String()
 		require.Contains(t, output, "Logs downloaded to")
 		require.Contains(t, output, "task-456-logs.zip")
+		require.Contains(t, s.mockStderr.String(), "Downloading logs...")
 	})
 
 	t.Run("when validation fails", func(t *testing.T) {