Skip to content

Commit 33523fd

Browse files
ryanbreenclaude
andcommitted
fix(userspace): remove unnecessary unsafe blocks around fork/execv
fork() and execv() in libbreenix are safe functions - the unsafe blocks were unnecessary and caused compiler warnings. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 3ac54e2 commit 33523fd

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

userspace/tests/cloexec_test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ pub extern "C" fn _start() -> ! {
4343
}
4444
close(write_fd);
4545

46-
let pid = unsafe { fork() };
46+
let pid = fork();
4747
if pid == 0 {
4848
let mut fd_buf = [0u8; 21];
4949
let fd_str = format_u64(read_fd, &mut fd_buf[..20]);
@@ -59,7 +59,7 @@ pub extern "C" fn _start() -> ! {
5959
core::ptr::null(),
6060
];
6161

62-
let _ = unsafe { execv(program, argv.as_ptr()) };
62+
let _ = execv(program, argv.as_ptr());
6363
println("exec failed");
6464
exit(1);
6565
} else if pid > 0 {

userspace/tests/exec_argv_test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use libbreenix::process::{execv, exit, fork, waitpid, wexitstatus, wifexited};
1010
pub extern "C" fn _start() -> ! {
1111
println("=== Exec Argv Test ===");
1212

13-
let pid = unsafe { fork() };
13+
let pid = fork();
1414
if pid == 0 {
1515
// Child: exec argv_test with specific args.
1616
let program = b"argv_test\0";
@@ -19,7 +19,7 @@ pub extern "C" fn _start() -> ! {
1919
let arg2 = b"world\0" as *const u8;
2020
let argv: [*const u8; 4] = [arg0, arg1, arg2, core::ptr::null()];
2121

22-
let _ = unsafe { execv(program, argv.as_ptr()) };
22+
let _ = execv(program, argv.as_ptr());
2323
// If we get here, exec failed.
2424
println("exec failed");
2525
exit(1);

0 commit comments

Comments
 (0)