Fix BufferUnpacker constructor to check against UnpackOptions instead of PackOptions

Author: rybakit

src/BufferUnpacker.php

@@ -39,7 +39,7 @@ public function __construct(string $buffer = '', $options = null, array $extensi
     {
         if (\is_null($options)) {
             $options = UnpackOptions::fromDefaults();
-        } elseif (!$options instanceof PackOptions) {
+        } elseif (!$options instanceof UnpackOptions) {
             $options = UnpackOptions::fromBitmask($options);
         }
 

tests/Unit/BufferUnpackerTest.php

@@ -331,6 +331,24 @@ public function testTryUnpackTruncatesBuffer() : void
         self::fail('Buffer was not truncated.');
     }
 
+    /**
+     * @dataProvider provideOptionsData
+     * @doesNotPerformAssertions
+     */
+    public function testConstructorSetsOptions($options) : void
+    {
+        new BufferUnpacker('', $options);
+    }
+
+    public function provideOptionsData() : iterable
+    {
+        return [
+            [0],
+            [null],
+            [UnpackOptions::fromDefaults()],
+        ];
+    }
+
     /**
      * @dataProvider provideInvalidOptionsData
      */

tests/Unit/PackerTest.php

@@ -76,9 +76,14 @@ public function provideOptionsData() : array
             [null, [0 => 1], "\x91\x01"],
             [PackOptions::DETECT_STR_BIN, "\x80", "\xc4\x01\x80"],
             [PackOptions::DETECT_STR_BIN, 'a', "\xa1\x61"],
+            [PackOptions::fromDefaults(), "\x80", "\xc4\x01\x80"],
+            [PackOptions::fromDefaults(), 'a', "\xa1\x61"],
             [PackOptions::FORCE_FLOAT64, 0.0, "\xcb\x00\x00\x00\x00\x00\x00\x00\x00"],
+            [PackOptions::fromDefaults(), 0.0, "\xcb\x00\x00\x00\x00\x00\x00\x00\x00"],
             [PackOptions::DETECT_ARR_MAP, [1 => 2], "\x81\x01\x02"],
             [PackOptions::DETECT_ARR_MAP, [0 => 1], "\x91\x01"],
+            [PackOptions::fromDefaults(), [1 => 2], "\x81\x01\x02"],
+            [PackOptions::fromDefaults(), [0 => 1], "\x91\x01"],
             [PackOptions::FORCE_STR, "\x80", "\xa1\x80"],
             [PackOptions::FORCE_BIN, 'a', "\xc4\x01\x61"],
             [PackOptions::FORCE_ARR, [1 => 2], "\x91\x02"],