Test edge cases when unpacking map keys

rybakit · rybakit · commit fc6bc45e9227 · 2022-02-16T01:48:07.000+01:00
diff --git a/tests/Unit/BufferUnpackerTest.php b/tests/Unit/BufferUnpackerTest.php
@@ -84,6 +84,8 @@ public function provideInsufficientData() : array
             'int64' => ["\xd3"],
             'float32' => ["\xca"],
             'float64' => ["\xcb"],
+            'mapkey' => ["\xdf\x00\x00\x00\x01"],
+            'mapkey_uint64' => ["\xdf\x00\x00\x00\x01\xcf"],
             'fixext1' => ["\xd4"],
             'fixext1t' => ["\xd4\x01"],
             'fixext2' => ["\xd5"],
@@ -675,6 +677,9 @@ public function provideMapWithInvalidKeyData() : iterable
                 yield ["\x81{$packed}\x00", $type]; // [$raw => 0]
             }
         }
+
+        // unknown key type
+        yield ["\x81\xc1\x00", '0xc1'];
     }
 
     public function testOverflowedUint64MapKeyIsConvertedToString() : void

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,8 @@ public function provideInsufficientData() : array`
`84`	`84`	`'int64' => ["\xd3"],`
`85`	`85`	`'float32' => ["\xca"],`
`86`	`86`	`'float64' => ["\xcb"],`
	`87`	`+ 'mapkey' => ["\xdf\x00\x00\x00\x01"],`
	`88`	`+ 'mapkey_uint64' => ["\xdf\x00\x00\x00\x01\xcf"],`
`87`	`89`	`'fixext1' => ["\xd4"],`
`88`	`90`	`'fixext1t' => ["\xd4\x01"],`
`89`	`91`	`'fixext2' => ["\xd5"],`
`@@ -675,6 +677,9 @@ public function provideMapWithInvalidKeyData() : iterable`
`675`	`677`	`yield ["\x81{$packed}\x00", $type]; // [$raw => 0]`
`676`	`678`	`}`
`677`	`679`	`}`
	`680`	`+`
	`681`	`+ // unknown key type`
	`682`	`+ yield ["\x81\xc1\x00", '0xc1'];`
`678`	`683`	`}`
`679`	`684`
`680`	`685`	`public function testOverflowedUint64MapKeyIsConvertedToString() : void`