Merge pull request #586 from ryceg:Fix-life-events

Add custom images

Author: ryceg

CHANGELOG.md

@@ -6,6 +6,21 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## 2.8.5
 
+### Added
+- Edit button to buildings that have an editor (it's still rather terrible, but at least now it's more visible)
+- Custom image uploading for Hero patrons accessible in the settings.
+
+### Changed
+- Fixed issue with Patreon thanks list sometimes breaking.
+- Modified formatting
+- Shifted notification down slightly so it does not collide with the header
+- Fixed an issue with Tippy not initialising for elements created in a table.
+
+### Removed
+- Obsolete 'Show Sliders' setting.
+
+## 2.8.5
+
 ### Added
 - Disable NSFW setting which removes slavery and brothels from being generated.
 - Unlocked GMBinder exporting for everyone because we hit 100 Patrons! Thanks!

lib/buildings/_common.ts

@@ -6,6 +6,7 @@ export interface Location {
   objectType: 'building'
   /** The type of building- 'castle', 'townSquare', 'generalStore', etc. */
   type: string
+  buildingType: string
   passageName?: string
   parentKey?: string
   name?: string

lib/npc-generation/createDescriptors.ts

@@ -1,6 +1,11 @@
 import { articles } from '../src/articles'
 import { NPC } from './_common'
 
+const getHumanOrRaceDescription = (npc: NPC) => {
+  if (npc.race === 'human') return `${lib.random([npc.weight, npc.height])} ${npc.manwoman}`
+  return `${lib.random([npc.weight, npc.height])} ${npc.malefemale} ${npc.raceName}`
+}
+
 export function createDescriptors (npc: NPC): string[] {
   console.log(`assigning descriptors to ${npc.name}...`)
 
@@ -9,9 +14,9 @@ export function createDescriptors (npc: NPC): string[] {
    * @see https://github.com/ryceg/Eigengrau-s-Essential-Establishment-Generator/wiki/Style-Guide#adjectives
    */
   const descriptors = [
-    `${npc.age || npc.ageStage} ${npc.raceName}`,
+    `${npc.age || npc.ageStage} ${npc.raceName} with ${npc.physicalTrait}`,
     `${npc.skinColour} skinned ${lib.random([npc.weight, npc.height])} ${npc.raceName}`,
-    `${lib.random([npc.weight, npc.height])} ${npc.raceName}`,
+    `${getHumanOrRaceDescription(npc)} with ${npc.physicalTrait}`,
     `${lib.random([npc.height, npc.age])} ${npc.gender} with ${npc.physicalTrait}`
   ]
 
@@ -22,11 +27,12 @@ export function createDescriptors (npc: NPC): string[] {
     default:
       switch (npc.race) {
         case 'human':
-          descriptors.push(`${lib.random([npc.weight, npc.height])} ${npc.manwoman}`)
           break
         default:
-          descriptors.push(`${lib.random([npc.weight, npc.height])} ${npc.malefemale} ${npc.raceName}`)
-          descriptors.push(`${lib.random([npc.weight, npc.height])} ${lib.raceTraits[npc.race].raceWords.raceAdjective} ${npc.manwoman}`)
+          descriptors.push(
+            getHumanOrRaceDescription(npc),
+            `${lib.random([npc.weight, npc.height])} ${lib.raceTraits[npc.race].raceWords.raceAdjective} ${npc.manwoman}`
+          )
       }
   }
 

lib/npc-generation/familyRelationships.ts

@@ -1,6 +1,7 @@
 import { roads } from '../town/roads'
 import { Town } from '../town/_common'
 import { Family, NPC } from './_common'
+import { random } from '../src/random'
 
 export const familyRelationships = {
   /**
@@ -107,15 +108,14 @@ export function createFamily (town: Town, npc: NPC) {
       road: ''
     }
   }
-  createFamilyHouse(town, family)
   town.families[key] = family
   npc.family = key
 }
 
 export function createFamilyHouse (town: Town, family: Family) {
   const road = town.roads[family.home.road] ||
   roads.findExisting(town) ||
-  lib.random(Object.keys(town.roads))
+  random(Object.keys(town.roads))
   // roads.assign(town)
 
   for (const member in family.members) {

lib/religion/religion.ts

@@ -262,6 +262,7 @@ export interface Deity {
    * @usage 'Hades resides in ______'
    */
   realm?: string
+  customImage?: URL
   followers: Partial<Followers>
   /**
    * If a deity particularly embodies a virtue or vice, it can be specified.

lib/src/createMagic.ts

@@ -3,7 +3,7 @@ import { magicData, MagicType } from './magicData'
 import { random } from './random'
 import { assign } from './utils'
 
-export function createMagic <T extends MagicType> (type: T | 'ring') {
+export function createMagic <T extends MagicType> (type: T | 'ring'): MagicItem {
   console.log(`Type: ${type}`)
 
   if (type === 'ring') {
@@ -33,3 +33,13 @@ export function createMagic <T extends MagicType> (type: T | 'ring') {
   console.log(magic)
   return magic
 }
+
+export interface MagicItem {
+  type: string
+  description: string
+  name: string
+  prefix?: string
+  suffix?: string
+  prefixProperty?: string
+  suffixProperty?: string
+}

lib/src/createRing.ts

@@ -1,3 +1,4 @@
+import { MagicItem } from '@lib'
 import { articles } from './articles'
 import { getRandomValue } from './getRandomValue'
 import { random } from './random'
@@ -9,7 +10,21 @@ interface Options {
   activation: string
 }
 
-export function createRing (base?: Partial<Options>) {
+interface MagicRing extends MagicItem {
+  works: string
+  material: string
+  decoration: string
+  gemstone: string
+  intendedowner: string
+  importance: string
+  setting: string
+  cut: string
+  power: string
+  cost: string
+  activation: string
+}
+
+export function createRing (base?: Partial<Options>): MagicRing {
   const ringData = createRingData()
 
   const ring = {
@@ -193,6 +208,11 @@ export function createRing (base?: Partial<Options>) {
     ])
   })
 
+  assign(ring, {
+    type: 'ring',
+    name: `${ring.gemstone} Ring`,
+    description: ring.firstOutputs
+  })
   return ring
 }
 

lib/src/getIllustration.ts

@@ -1,44 +1,39 @@
-import { Town } from '../town/_common'
-
 type Illustration =
 | 'general-store-illustration'
 | 'tavern-illustration'
 | 'town-illustration'
 | 'city-illustration'
 
-export const getIllustration = (illustration: Illustration, alt: string) => {
-  let img = '<img '
-  img += 'id="illustration" '
-  const path = getPath()
-
-  img += `src="${path}src/Resources/img/hero/${illustration}.jpg" `
-  // If it's in production, then we can add the srcset options, otherwise we might as well omit it.
-  if (process.env.NODE_ENV === 'production' && location.origin !== 'file://') img += `srcset="${path}src/Resources/img/hero/${illustration}-x360.jpg 360w, ${path}src/Resources/img/hero/${illustration}-x411.jpg 411w, ${path}src/Resources/img/hero/${illustration}-x500.jpg 500w, ${path}src/Resources/img/hero/${illustration}-x576.jpg 576w, ${path}src/Resources/img/hero/${illustration}-x768.jpg 768w, ${path}src/Resources/img/hero/${illustration}-x992.jpg 992w, ${path}src/Resources/img/hero/${illustration}-x1200.jpg 1200w, ${path}src/Resources/img/hero/${illustration}.jpg" `
-  img += `alt="${alt || `An image depicting ${lib.articles.output(illustration)}, created by artist Juho Huttunen.`}" `
-  img += '/>'
-  return img
-}
-
 const getPath = () => {
   if (process.env.NODE_ENV === 'production' && location.origin !== 'file://') {
     return './'
   }
   return '../'
 }
 
-// It would obviously be preferable to output actual <img>s instead of having it render via SugarCube.
-// Unfortunately, I am not a clever man, and cannot figure it out.
-export const getImage = (illustration: Illustration) => {
+const addLocalSourceSet = (illustration: Illustration, sizes: string[] = ['360', '411', '500', '576', '768', '992', '1200']) => {
+  let img = ''
+  const path = getPath()
+  for (const size of sizes) {
+    img += `${path}src/Resources/img/hero/${illustration}-x${size}.jpg ${size}w, `
+  }
+  return img
+}
+
+export const getCustomImage = (url: URL) => {
+  const img = document.createElement('img')
+  img.id = 'illustration'
+  img.src = url as unknown as string
+  img.alt = 'A custom-defined image.'
+  return img.outerHTML
+}
+
+export const getLocalImage = (illustration: Illustration) => {
   const img = document.createElement('img')
   const path = getPath()
   img.id = 'illustration'
   img.src = `${path}src/Resources/img/hero/${illustration}.jpg`
-  img.srcset = `${path}src/Resources/img/hero/${illustration}-x360.jpg 360w, ${path}src/Resources/img/hero/${illustration}-x411.jpg 411w, ${path}src/Resources/img/hero/${illustration}-x500.jpg 500w, ${path}src/Resources/img/hero/${illustration}-x576.jpg 576w, ${path}src/Resources/img/hero/${illustration}-x768.jpg 768w, ${path}src/Resources/img/hero/${illustration}-x992.jpg 992w, ${path}src/Resources/img/hero/${illustration}-x1200.jpg 1200w, ${path}src/Resources/img/hero/${illustration}.jpg`
+  if (process.env.NODE_ENV === 'production' && location.origin !== 'file://') img.srcset = `${addLocalSourceSet(illustration)} ${path}src/Resources/img/hero/${illustration}.jpg`
   img.alt = `An image depicting ${lib.articles.output(illustration)}, created by artist Juho Huttunen.`
-  return img
-}
-
-export const townOrCity = (town: Town) => {
-  if (town.type === 'city' || town.type === 'town') return 'city-illustration'
-  return 'town-illustration'
+  return img.outerHTML
 }

lib/town/_common.ts

@@ -68,6 +68,7 @@ export interface TownProfessions extends Profession {
 }
 
 export interface Town extends TownBasics {
+  localImage: string
   taxes: {
     welfare: number
     military: number

lib/town/townRender.ts

@@ -1,9 +1,16 @@
 import { Town } from './_common'
 import { getPolice } from './getPolice'
 
+export const townOrCity = (town: Town) => {
+  if (town.type === 'city' || town.type === 'town') return 'city-illustration'
+  return 'town-illustration'
+}
+
 export function townRender (town: Town) {
   console.log(`Rendering ${town.name}...`)
 
+  town.localImage = townOrCity(town)
+
   town.roll.guardFunding = 0
 
   const police = getPolice(town.factions)