Skip to content

Commit 2e5e90e

Browse files
adcoelhoadcoelho
authored
[ResponseOps] Fix failing connector form tests (elastic#235199)
Closes elastic#231007 Closes elastic#227548 ## Summary Two changes: 1. Every test creates a connector. Searching for the created connector is sometimes slow, and the table does not render immediately. I wrapped these searches in retry blocks. 2. Every test creates a connector, but they were only removed at the end. I changed `after` to `afterEach` ## Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9328
1 parent 2f4b19b commit 2e5e90e

File tree

1 file changed

+41
-32
lines changed
  • x-pack/platform/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors

1 file changed

+41
-32
lines changed

‎x-pack/platform/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/general.ts‎

Lines changed: 41 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
3939
await pageObjects.common.navigateToApp('triggersActionsConnectors');
4040
});
4141

42-
after(async () => {
42+
afterEach(async () => {
4343
await objectRemover.removeAll();
4444
});
4545

@@ -89,9 +89,10 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
8989
await browser.refresh();
9090

9191
await pageObjects.triggersActionsUI.searchConnectors(connectorName);
92-
93-
const searchResultsBeforeEdit = await pageObjects.triggersActionsUI.getConnectorsList();
94-
expect(searchResultsBeforeEdit.length).to.eql(1);
92+
await retry.try(async () => {
93+
const searchResultsBeforeEdit = await pageObjects.triggersActionsUI.getConnectorsList();
94+
expect(searchResultsBeforeEdit.length).to.eql(1);
95+
});
9596

9697
await find.clickByCssSelector('[data-test-subj="connectorsTableCell-name"] button');
9798

@@ -127,9 +128,10 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
127128
await browser.refresh();
128129

129130
await pageObjects.triggersActionsUI.searchConnectors(connectorName);
130-
131-
const searchResultsBeforeEdit = await pageObjects.triggersActionsUI.getConnectorsList();
132-
expect(searchResultsBeforeEdit.length).to.eql(1);
131+
await retry.try(async () => {
132+
const searchResultsBeforeEdit = await pageObjects.triggersActionsUI.getConnectorsList();
133+
expect(searchResultsBeforeEdit.length).to.eql(1);
134+
});
133135

134136
await find.clickByCssSelector('[data-test-subj="connectorsTableCell-name"] button');
135137

@@ -157,9 +159,10 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
157159
await browser.refresh();
158160

159161
await pageObjects.triggersActionsUI.searchConnectors(connectorName);
160-
161-
const searchResultsBeforeEdit = await pageObjects.triggersActionsUI.getConnectorsList();
162-
expect(searchResultsBeforeEdit.length).to.eql(1);
162+
await retry.try(async () => {
163+
const searchResultsBeforeTest = await pageObjects.triggersActionsUI.getConnectorsList();
164+
expect(searchResultsBeforeTest.length).to.eql(1);
165+
});
163166

164167
await find.clickByCssSelector('[data-test-subj="connectorsTableCell-name"] button');
165168

@@ -188,9 +191,10 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
188191
await browser.refresh();
189192

190193
await pageObjects.triggersActionsUI.searchConnectors(connectorName);
191-
192-
const searchResultsBeforeEdit = await pageObjects.triggersActionsUI.getConnectorsList();
193-
expect(searchResultsBeforeEdit.length).to.eql(1);
194+
await retry.try(async () => {
195+
const searchResultsBeforeEdit = await pageObjects.triggersActionsUI.getConnectorsList();
196+
expect(searchResultsBeforeEdit.length).to.eql(1);
197+
});
194198

195199
await find.clickByCssSelector('[data-test-subj="connectorsTableCell-name"] button');
196200

@@ -220,9 +224,10 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
220224
await browser.refresh();
221225

222226
await pageObjects.triggersActionsUI.searchConnectors(connectorName);
223-
224-
const searchResultsBeforeDelete = await pageObjects.triggersActionsUI.getConnectorsList();
225-
expect(searchResultsBeforeDelete.length).to.eql(1);
227+
await retry.try(async () => {
228+
const searchResultsBeforeDelete = await pageObjects.triggersActionsUI.getConnectorsList();
229+
expect(searchResultsBeforeDelete.length).to.eql(1);
230+
});
226231

227232
await testSubjects.click('deleteConnector');
228233
await testSubjects.existOrFail('deleteIdsConfirmation');
@@ -233,9 +238,10 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
233238
expect(toastTitle).to.eql('Deleted 1 connector');
234239

235240
await pageObjects.triggersActionsUI.searchConnectors(connectorName);
236-
237-
const searchResultsAfterDelete = await pageObjects.triggersActionsUI.getConnectorsList();
238-
expect(searchResultsAfterDelete.length).to.eql(0);
241+
await retry.try(async () => {
242+
const searchResultsAfterDelete = await pageObjects.triggersActionsUI.getConnectorsList();
243+
expect(searchResultsAfterDelete.length).to.eql(0);
244+
});
239245
});
240246

241247
it('should bulk delete connectors', async () => {
@@ -249,10 +255,10 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
249255
await browser.refresh();
250256

251257
await pageObjects.triggersActionsUI.searchConnectors(connectorName);
252-
253-
const searchResultsBeforeDelete = await pageObjects.triggersActionsUI.getConnectorsList();
254-
expect(searchResultsBeforeDelete.length).to.eql(1);
255-
258+
await retry.try(async () => {
259+
const searchResultsBeforeDelete = await pageObjects.triggersActionsUI.getConnectorsList();
260+
expect(searchResultsBeforeDelete.length).to.eql(1);
261+
});
256262
await find.clickByCssSelector('.euiTableRowCellCheckbox .euiCheckbox__input');
257263

258264
await testSubjects.click('bulkDelete');
@@ -264,17 +270,19 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
264270
expect(toastTitle).to.eql('Deleted 1 connector');
265271

266272
await pageObjects.triggersActionsUI.searchConnectors(connectorName);
267-
268-
const searchResultsAfterDelete = await pageObjects.triggersActionsUI.getConnectorsList();
269-
expect(searchResultsAfterDelete.length).to.eql(0);
273+
await retry.try(async () => {
274+
const searchResultsAfterDelete = await pageObjects.triggersActionsUI.getConnectorsList();
275+
expect(searchResultsAfterDelete.length).to.eql(0);
276+
});
270277
});
271278

272279
it('should not be able to delete a preconfigured connector', async () => {
273280
const preconfiguredConnectorName = 'Serverlog';
274281
await pageObjects.triggersActionsUI.searchConnectors(preconfiguredConnectorName);
275-
276-
const searchResults = await pageObjects.triggersActionsUI.getConnectorsList();
277-
expect(searchResults.length).to.eql(1);
282+
await retry.try(async () => {
283+
const searchResults = await pageObjects.triggersActionsUI.getConnectorsList();
284+
expect(searchResults.length).to.eql(1);
285+
});
278286

279287
expect(await testSubjects.exists('deleteConnector')).to.be(false);
280288
expect(await testSubjects.exists('preConfiguredTitleMessage')).to.be(true);
@@ -287,9 +295,10 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
287295
const preconfiguredConnectorName = 'test-preconfigured-email';
288296

289297
await pageObjects.triggersActionsUI.searchConnectors(preconfiguredConnectorName);
290-
291-
const searchResultsBeforeEdit = await pageObjects.triggersActionsUI.getConnectorsList();
292-
expect(searchResultsBeforeEdit.length).to.eql(1);
298+
await retry.try(async () => {
299+
const searchResultsBeforeEdit = await pageObjects.triggersActionsUI.getConnectorsList();
300+
expect(searchResultsBeforeEdit.length).to.eql(1);
301+
});
293302

294303
expect(await testSubjects.exists('preConfiguredTitleMessage')).to.be(true);
295304
await find.clickByCssSelector('[data-test-subj="connectorsTableCell-name"] button');

0 commit comments

Comments
 (0)