Skip to content

Commit 9e64dd9

Browse files
[Streams] Change data quality flyout from overlay to push (elastic#235044)
## Summary Closes elastic#233507 This PR changes the `QualityIssueFlyout` back to push flyout type (it was changed to `overlay` in elastic#231169). Changes: - Changed `QualityIssueFlyout` to `type="push"` - Brought back the deleted functional tests.
1 parent ba85a0a commit 9e64dd9

File tree

3 files changed

+42
-1
lines changed

3 files changed

+42
-1
lines changed

x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/quality_issue_flyout/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ export default function QualityIssueFlyout() {
9090

9191
return (
9292
<EuiFlyout
93-
maxWidth={450}
93+
type="push"
94+
size="s"
9495
onClose={closeDegradedFieldFlyout}
9596
aria-labelledby={pushedFlyoutTitleId}
9697
data-test-subj={'datasetQualityDetailsDegradedFieldFlyout'}

x-pack/solutions/observability/test/functional/apps/dataset_quality/degraded_field_flyout.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,26 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
528528
PageObjects.datasetQuality.testSubjectSelectors.datasetQualityDetailsDegradedFieldFlyout
529529
);
530530
});
531+
532+
it('should close the flyout when current quality switch is toggled on and the flyout is already open with an old field ', async () => {
533+
await PageObjects.datasetQuality.navigateToDetails({
534+
dataStream: degradedDatasetWithLimitDataStreamName,
535+
expandedDegradedField: 'cloud',
536+
});
537+
538+
await testSubjects.existOrFail(
539+
PageObjects.datasetQuality.testSubjectSelectors.datasetQualityDetailsDegradedFieldFlyout
540+
);
541+
542+
await testSubjects.click(
543+
PageObjects.datasetQuality.testSubjectSelectors
544+
.datasetQualityDetailsOverviewDegradedFieldToggleSwitch
545+
);
546+
547+
await testSubjects.missingOrFail(
548+
PageObjects.datasetQuality.testSubjectSelectors.datasetQualityDetailsDegradedFieldFlyout
549+
);
550+
});
531551
});
532552

533553
describe('character limit exceeded', () => {

x-pack/solutions/observability/test/serverless/functional/test_suites/dataset_quality/degraded_field_flyout.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,26 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
526526
PageObjects.datasetQuality.testSubjectSelectors.datasetQualityDetailsDegradedFieldFlyout
527527
);
528528
});
529+
530+
it('should close the flyout when current quality switch is toggled on and the flyout is already open with an old field ', async () => {
531+
await PageObjects.datasetQuality.navigateToDetails({
532+
dataStream: degradedDatasetWithLimitDataStreamName,
533+
expandedDegradedField: 'cloud',
534+
});
535+
536+
await testSubjects.existOrFail(
537+
PageObjects.datasetQuality.testSubjectSelectors.datasetQualityDetailsDegradedFieldFlyout
538+
);
539+
540+
await testSubjects.click(
541+
PageObjects.datasetQuality.testSubjectSelectors
542+
.datasetQualityDetailsOverviewDegradedFieldToggleSwitch
543+
);
544+
545+
await testSubjects.missingOrFail(
546+
PageObjects.datasetQuality.testSubjectSelectors.datasetQualityDetailsDegradedFieldFlyout
547+
);
548+
});
529549
});
530550

531551
describe('character limit exceeded', () => {

0 commit comments

Comments
 (0)