Fix parameter type in notification callback and initialize Event after event loop initialization (#64)

* Fix parameter type in notification callback and initialize asyncio Event after event loop has been initialized

* Fix linting & fallback to older characteristic access on exceptions

* Fix flake8 precommit url

Co-authored-by: Teemu Rytilahti <[email protected]>

Author: krakowski

eq3bt/bleakconnection.py

@@ -31,15 +31,18 @@ def __init__(self, mac, iface):
         self._mac = mac
         self._iface = iface
         self._callbacks = {}
-        self._notifyevent = asyncio.Event()
         self._notification_handle = None
 
         try:
             self._loop = asyncio.get_running_loop()
+            _LOGGER.debug("Using existing asyncio loop")
         except RuntimeError:
             self._loop = asyncio.new_event_loop()
+            _LOGGER.debug("Creating new asyncio loop")
             asyncio.set_event_loop(self._loop)
 
+        self._notifyevent = asyncio.Event()
+
     def __enter__(self):
         """
         Context manager __enter__ for connecting the device
@@ -79,10 +82,14 @@ def __exit__(self, exc_type, exc_val, exc_tb):
             self._loop.run_until_complete(self._conn.disconnect())
             self._conn = None
 
-    async def on_notification(self, handle, data):
+    async def on_notification(self, characteristic, data):
         """Handle Callback from a Bluetooth (GATT) request."""
         # The notification handles are off-by-one compared to gattlib and bluepy
-        handle = handle + 1
+        try:
+            handle = characteristic.handle + 1
+        except:  # noqa: E722 # fallback to old-style, int-based handle
+            handle = characteristic + 1
+
         _LOGGER.debug(
             "Got notification from %s: %s", handle, codecs.encode(data, "hex")
         )