Skip to content

Commit e311d66

Browse files
committed
UIC-3202: Relax compiler warnings to support more compilers
Threating warning as error is a good practice durring development phase, for release it's ok to relax this to support more (future) compilers and then provide best effort support on non supported environements. For instance we might allow users to support stable version of gcc (gcc-13 currently which is not yet enabled in our CI) Of course this change should be reverted on development branch, ASAP, and introduced again for next releases. Ideally it should be near to release tags. For the record it was useful to support MacOS: ``` ➜ ~ cc --version Apple clang version 15.0.0 (clang-1500.3.9.4) Target: x86_64-apple-darwin23.4.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin ➜ ~ c++ --version Apple clang version 15.0.0 (clang-1500.3.9.4) Target: x86_64-apple-darwin23.4.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin ``` Origin: uic/pull-requests/2704/overview Relate-to: uic/pull-requests/2705/overview?commentId=796680 Relate-to: /x/FND4Dg#BrainstormItems-Identifystandardsbreakage Forwarded: uic/pull-requests/2704/overview Forwarded: SiliconLabsSoftware/z-wave-protocol-controller#25 Signed-off-by: Philippe Coval <[email protected]>
1 parent fb360ad commit e311d66

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cmake/include/compiler_options.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON) # Do not allow fallback to previous C++
3131
set(CMAKE_CXX_EXTENSIONS ON) # Enable gnu++11 extentions
3232

3333
# Set compiler Flags
34-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -pipe -Werror -Wall")
35-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pipe -Werror -Wall")
34+
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -pipe -Wall")
35+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pipe -Wall")
3636

3737
# Only add code coverage when CMAKE_GCOV is True
3838
if(CMAKE_GCOV)

0 commit comments

Comments
 (0)