fix(cc): Fix class_configuration_control check with frame without cmd

Test has been hardened as well, without the fix it will fail

Origin: SiliconLabsSoftware#116
Relate-to: SiliconLabsSoftware#110 (comment)
Relate-to: SiliconLabsSoftware#111 (comment)
Thanks-to: Laudin Molina Troconis <[email protected]>
Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10
Signed-off-by: Philippe Coval <[email protected]>

Author: rzr

applications/zpc/components/zwave_command_classes/src/zwave_command_class_configuration_control.c

@@ -915,7 +915,7 @@ static sl_status_t zwave_command_class_configuration_control_handler(
   const uint8_t *frame,
   uint16_t frame_length)
 {
-  if (frame_length < COMMAND_INDEX) {
+  if (frame_length <= COMMAND_INDEX) {
     return SL_STATUS_NOT_SUPPORTED;
   }
 

applications/zpc/components/zwave_command_classes/test/zwave_command_class_configuration_control_test.c

@@ -1626,14 +1626,18 @@ void test_zwave_command_class_configuration_unknown_command()
 
 void test_zwave_command_class_configuration_no_command()
 {
-  const uint8_t incoming_frame[] = {COMMAND_CLASS_CONFIGURATION_V4};
+  const uint8_t incoming_frame[] = {
+    COMMAND_CLASS_CONFIGURATION_V4,
+    CONFIGURATION_REPORT_V4  // Add deterministic valid value for overflow check
+  };
 
   TEST_ASSERT_NOT_NULL(configuration_handler.control_handler);
-  TEST_ASSERT_EQUAL(
-    SL_STATUS_NOT_SUPPORTED,
-    configuration_handler.control_handler(&connection_info,
-                                          incoming_frame,
-                                          sizeof(incoming_frame)));
+  TEST_ASSERT_EQUAL(SL_STATUS_NOT_SUPPORTED,
+                    configuration_handler.control_handler(
+                      &connection_info,
+                      incoming_frame,
+                      sizeof(incoming_frame) - 1  // Remove padding
+                      ));
 }
 
 void test_zwave_command_class_configuration_non_existing_parameter()
@@ -1968,4 +1972,4 @@ void test_give_up_on_configuration_get_v3_node()
   on_configuration_get_failure(test_node);
   TEST_ASSERT_TRUE(attribute_store_node_exists(parameter_id_node));
   TEST_ASSERT_TRUE(attribute_store_node_exists(test_node));
-}
+}