fix(cc): Fix meter_control_test check on frame without cmd

Also fix related test, to always fail:

102 - zwave_command_class_meter_control_test (Failed)

For some reason I dont remember seeing it failed
despite the read should be invalid, this should be triggered by CI

Origin: SiliconLabsSoftware#117
Relate-to: SiliconLabsSoftware#110 (comment)
Relate-to: SiliconLabsSoftware#111 (comment)
Thanks-to: Laudin Molina Troconis <[email protected]>
Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10
Signed-off-by: Philippe Coval <[email protected]>

Author: rzr

applications/zpc/components/zwave_command_classes/src/zwave_command_class_meter_control.c

@@ -742,7 +742,7 @@ static sl_status_t zwave_command_class_meter_control_handler(
   const uint8_t *frame,
   uint16_t frame_length)
 {
-  if (frame_length < COMMAND_INDEX) {
+  if (frame_length <= COMMAND_INDEX) {
     return SL_STATUS_NOT_SUPPORTED;
   }
 
@@ -823,4 +823,4 @@ sl_status_t zwave_command_class_meter_control_init()
   zwave_command_handler_register_handler(handler);
 
   return SL_STATUS_OK;
-}
+}

applications/zpc/components/zwave_command_classes/test/zwave_command_class_meter_control_test.c

@@ -854,13 +854,16 @@ void test_meter_report_too_short()
 void test_meter_command_class_no_command()
 {
   // Simulate a frame
-  const uint8_t incoming_frame[] = {COMMAND_CLASS_METER};
+  const uint8_t incoming_frame[] = {COMMAND_CLASS_METER,
+      METER_REPORT_V5, // Add deterministic valid value for overflow check
+    };
 
   TEST_ASSERT_NOT_NULL(meter_handler.control_handler);
   TEST_ASSERT_EQUAL(SL_STATUS_NOT_SUPPORTED,
                     meter_handler.control_handler(&info,
                                                   incoming_frame,
-                                                  sizeof(incoming_frame)));
+                                                  sizeof(incoming_frame) -1 // Remove padding
+                        ));
 }
 
 void test_supported_rate_types_unknown_values()