Skip to content

Commit f956979

Browse files
ci: github: Harden the test workflow by using runner temp dir
This issue was reported by CodeQL, IMHOI the alert was over reacting because contents was already extracted in a separate directory (which is absent in tree, so there is no risk to override) An extra check would be to verify a signed asset (using GPG), along a ZWA public key shared in tree. Potential fix for code scanning alert no. 1: Artifact poisoning Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Relate-to: Z-Wave-Alliance/OSWG#48 (comment) Signed-off-by: Philippe Coval <[email protected]>
1 parent 8bc24a8 commit f956979

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ jobs:
5959
${{ env.debian_packages }}
6060
&& sudo apt-get clean -y
6161
&& echo "https://github.com/Z-Wave-Alliance/z-wave-stack/issues/733"
62-
&& mkdir -p z-wave-stack-binaries
62+
&& mkdir -p ${{ runner.temp }}/z-wave-stack-binaries
6363
&& tar xfz z-wave-stack-binaries-*-Linux.tar.gz
64-
-C z-wave-stack-binaries
64+
-C ${{ runner.temp }}/z-wave-stack-binaries
6565
&& rm z-wave-stack-binaries-*-Linux.tar.gz
6666
&& date -u
6767
@@ -74,7 +74,7 @@ jobs:
7474
$ZPC_COMMAND --version
7575
docker-compose pull
7676
export ZPC_COMMAND="docker-compose up --abort-on-container-exit"
77-
cd z-wave-stack-binaries/bin && file -E *_x86_REALTIME.elf && cd -
77+
export z_wave_stack_binaries_bin_dir="${{ runner.temp }}/z-wave-stack-binaries/bin"
7878
export ZPC_ARGS="--log.level=d"
7979
./scripts/tests/z-wave-stack-binaries-test.sh
8080
continue-on-error: true

0 commit comments

Comments
 (0)