fix(cc): Fix central_scene handler on frame without cmd

Adding determinist test as well as suggested in related review.

Origin: SiliconLabsSoftware#115
Relate-to: SiliconLabsSoftware#110 (comment)
Relate-to: SiliconLabsSoftware#111 (comment)
Thanks-to: Laudin Molina Troconis <[email protected]>
Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10
Signed-off-by: Philippe Coval <[email protected]>

Author: rzr

applications/zpc/components/zwave_command_classes/src/zwave_command_class_central_scene.c

@@ -554,7 +554,7 @@ static sl_status_t zwave_command_class_central_scene_control_handler(
   const uint8_t *frame,
   uint16_t frame_length)
 {
-  if (frame_length < COMMAND_INDEX) {
+  if (frame_length <= COMMAND_INDEX) { // Should contain at least class and cmd
     return SL_STATUS_NOT_SUPPORTED;
   }
 
@@ -793,4 +793,4 @@ sl_status_t zwave_command_class_central_scene_init()
   zwave_command_handler_register_handler(handler);
 
   return SL_STATUS_OK;
-}
+}

applications/zpc/components/zwave_command_classes/test/zwave_command_class_central_scene_test.c

@@ -346,13 +346,17 @@ void test_zwave_command_class_central_scene_configuration_set_no_slow_refresh()
 void test_zwave_command_class_central_scene_frame_too_short()
 {
   TEST_ASSERT_NOT_NULL(central_scene_handler.control_handler);
-  const uint8_t incoming_frame[] = {COMMAND_CLASS_CENTRAL_SCENE_V3};
-
-  TEST_ASSERT_EQUAL(
-    SL_STATUS_NOT_SUPPORTED,
-    central_scene_handler.control_handler(&connection_info,
+  const uint8_t incoming_frame[] = {
+    COMMAND_CLASS_CENTRAL_SCENE_V3,
+    CENTRAL_SCENE_NOTIFICATION_V3  // Padding with deterministic valid cmd if overflow
+  };
+
+  TEST_ASSERT_EQUAL(SL_STATUS_NOT_SUPPORTED,
+                    central_scene_handler.control_handler(
+                      &connection_info,
                                           incoming_frame,
-                                          sizeof(incoming_frame)));
+                      sizeof(incoming_frame) - 1  // remove padding
+                      ));
 }
 
 void test_zwave_command_class_central_scene_frame_wrong_command_class()
@@ -963,4 +967,4 @@ void test_zwave_command_class_central_scene_notification_return_scene_to_idle()
   TEST_ASSERT_NOT_NULL(return_scene_to_idle);
   return_scene_to_idle(endpoint_id_node);
   verify_attribute_store_data_notification(0, 0);
-}
+}